Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15383950
D16171.id38902.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D16171.id38902.diff
View Options
diff --git a/src/infrastructure/edges/engineextension/PhabricatorEdgesDestructionEngineExtension.php b/src/infrastructure/edges/engineextension/PhabricatorEdgesDestructionEngineExtension.php
--- a/src/infrastructure/edges/engineextension/PhabricatorEdgesDestructionEngineExtension.php
+++ b/src/infrastructure/edges/engineextension/PhabricatorEdgesDestructionEngineExtension.php
@@ -28,10 +28,20 @@
foreach ($edges as $type => $type_edges) {
foreach ($type_edges as $src => $src_edges) {
foreach ($src_edges as $dst => $edge) {
- $editor->removeEdge($edge['src'], $edge['type'], $edge['dst']);
+ try {
+ $editor->removeEdge($edge['src'], $edge['type'], $edge['dst']);
+ } catch (Exception $ex) {
+ // We can run into an exception while removing the edge if the
+ // edge type no longer exists. This prevents us from figuring out
+ // if there's an inverse type. Just ignore any errors here and
+ // continue, since the best we can do is clean up all the edges
+ // we still have information about. See T11201.
+ phlog($ex);
+ }
}
}
}
+
$editor->save();
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Mar 15, 6:24 PM (1 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7700854
Default Alt Text
D16171.id38902.diff (1 KB)
Attached To
Mode
D16171: Log and continue when trying to destroy edges with no edge definition
Attached
Detach File
Event Timeline
Log In to Comment