D15774.id38004.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D15774.id38004.diff
View Options

	diff --git a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
	--- a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
	+++ b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
	@@ -1227,7 +1227,17 @@
	// Make this weaker than TYPE_COMMENT.
	return 0.25;
	}
	- break;
	+
	+ if ($this->isApplicationAuthor()) {
	+ // When applications (most often: Herald) change subscriptions it
	+ // is very uninteresting.
	+ return 0.000000001;
	+ }
	+
	+ // In other cases, subscriptions are more interesting than comments
	+ // (which are shown anyway) but less interesting than any other type of
	+ // transaction.
	+ return 0.75;
	}

	return 1.0;
	@@ -1462,6 +1472,14 @@
	return true;
	}

	+ private function isApplicationAuthor() {
	+ $author_phid = $this->getAuthorPHID();
	+ $author_type = phid_get_type($author_phid);
	+ $application_type = PhabricatorApplicationApplicationPHIDType::TYPECONST;
	+ return ($author_type == $application_type);
	+ }
	+
	+
	private function getInterestingMoves(array $moves) {
	// Remove moves which only shift the position of a task within a column.
	foreach ($moves as $key => $move) {