Page MenuHomePhabricator

D13054.id.diff
No OneTemporary

D13054.id.diff

diff --git a/src/applications/drydock/view/DrydockLeaseListView.php b/src/applications/drydock/view/DrydockLeaseListView.php
--- a/src/applications/drydock/view/DrydockLeaseListView.php
+++ b/src/applications/drydock/view/DrydockLeaseListView.php
@@ -42,9 +42,9 @@
$item->setEpoch($lease->getDateCreated());
if ($lease->isActive()) {
- $item->setStatusIcon('fa-dot-circle green');
+ $item->setStatusIcon('fa-dot-circle-o green');
} else {
- $item->setStatusIcon('fa-dot-circle red');
+ $item->setStatusIcon('fa-dot-circle-o red');
}
$view->addItem($item);
diff --git a/src/applications/drydock/view/DrydockResourceListView.php b/src/applications/drydock/view/DrydockResourceListView.php
--- a/src/applications/drydock/view/DrydockResourceListView.php
+++ b/src/applications/drydock/view/DrydockResourceListView.php
@@ -27,16 +27,16 @@
switch ($resource->getStatus()) {
case DrydockResourceStatus::STATUS_PENDING:
- $item->setStatusIcon('fa-dot-circle yellow');
+ $item->setStatusIcon('fa-dot-circle-o yellow');
break;
case DrydockResourceStatus::STATUS_OPEN:
- $item->setStatusIcon('fa-dot-circle green');
+ $item->setStatusIcon('fa-dot-circle-o green');
break;
case DrydockResourceStatus::STATUS_DESTROYED:
- $item->setStatusIcon('fa-times-circle black');
+ $item->setStatusIcon('fa-times-circle-o black');
break;
default:
- $item->setStatusIcon('fa-dot-circle red');
+ $item->setStatusIcon('fa-dot-circle-o red');
break;
}
diff --git a/src/applications/harbormaster/controller/HarbormasterBuildableViewController.php b/src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
--- a/src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
+++ b/src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
@@ -175,7 +175,9 @@
->setHref($view_uri);
$status = $build->getBuildStatus();
- $item->setBarColor(HarbormasterBuild::getBuildStatusColor($status));
+ $item->setStatusIcon(
+ 'fa-dot-circle-o '.HarbormasterBuild::getBuildStatusColor($status),
+ HarbormasterBuild::getBuildStatusName($status));
$item->addAttribute(HarbormasterBuild::getBuildStatusName($status));
diff --git a/src/applications/harbormaster/controller/HarbormasterPlanViewController.php b/src/applications/harbormaster/controller/HarbormasterPlanViewController.php
--- a/src/applications/harbormaster/controller/HarbormasterPlanViewController.php
+++ b/src/applications/harbormaster/controller/HarbormasterPlanViewController.php
@@ -122,7 +122,7 @@
$item = id(new PHUIObjectItemView())
->setObjectName(pht('Step %d.%d', $depth, $i))
->setHeader(pht('Unknown Implementation'))
- ->setBarColor('red')
+ ->setStatusIcon('fa-warning red')
->addAttribute(pht(
'This step has an invalid implementation (%s).',
$step->getClassName()))
@@ -208,7 +208,7 @@
if ($has_conflicts) {
$has_any_conflicts = true;
- $item->setBarColor('red');
+ $item->setStatusIcon('fa-warning red');
}
if ($run_ref['cycle']) {
@@ -216,7 +216,7 @@
}
if ($is_deadlocking) {
- $item->setBarColor('red');
+ $item->setStatusIcon('fa-warning red');
}
$step_list->addItem($item);
diff --git a/src/applications/people/controller/PhabricatorPeopleLdapController.php b/src/applications/people/controller/PhabricatorPeopleLdapController.php
--- a/src/applications/people/controller/PhabricatorPeopleLdapController.php
+++ b/src/applications/people/controller/PhabricatorPeopleLdapController.php
@@ -101,17 +101,17 @@
$header = pht('Successfully added %s', $username);
$attribute = null;
- $color = 'green';
+ $color = 'fa-check green';
} catch (Exception $ex) {
$header = pht('Failed to add %s', $username);
$attribute = $ex->getMessage();
- $color = 'red';
+ $color = 'fa-times red';
}
$item = id(new PHUIObjectItemView())
->setHeader($header)
->addAttribute($attribute)
- ->setBarColor($color);
+ ->setStatusIcon($color);
$list->addItem($item);
}

File Metadata

Mime Type
text/plain
Expires
Sat, Mar 15, 1:57 PM (2 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7695179
Default Alt Text
D13054.id.diff (4 KB)

Event Timeline