Page MenuHomePhabricator

D18285.id43978.diff
No OneTemporary

D18285.id43978.diff

diff --git a/src/applications/ponder/controller/PonderQuestionViewController.php b/src/applications/ponder/controller/PonderQuestionViewController.php
--- a/src/applications/ponder/controller/PonderQuestionViewController.php
+++ b/src/applications/ponder/controller/PonderQuestionViewController.php
@@ -94,7 +94,7 @@
$wiki = new PHUIRemarkupView($viewer, $question->getAnswerWiki());
$answer_wiki = id(new PHUIObjectBoxView())
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
- ->setHeaderText(pht('ANSWER SUMMARY'))
+ ->setHeaderText(pht('Answer Summary'))
->appendChild($wiki)
->addClass('ponder-answer-wiki');
}
diff --git a/src/applications/ponder/editor/PonderQuestionEditor.php b/src/applications/ponder/editor/PonderQuestionEditor.php
--- a/src/applications/ponder/editor/PonderQuestionEditor.php
+++ b/src/applications/ponder/editor/PonderQuestionEditor.php
@@ -10,11 +10,11 @@
}
public function getCreateObjectTitle($author, $object) {
- return pht('%s created this question.', $author);
+ return pht('%s asked this question.', $author);
}
public function getCreateObjectTitleForFeed($author, $object) {
- return pht('%s created %s.', $author, $object);
+ return pht('%s asked %s.', $author, $object);
}
/**
diff --git a/src/applications/ponder/storage/PonderAnswerTransaction.php b/src/applications/ponder/storage/PonderAnswerTransaction.php
--- a/src/applications/ponder/storage/PonderAnswerTransaction.php
+++ b/src/applications/ponder/storage/PonderAnswerTransaction.php
@@ -23,4 +23,11 @@
return 'PonderAnswerTransactionType';
}
+ public function getMailTags() {
+ $tags = parent::getMailTags();
+ $tags[] = PonderQuestionTransaction::MAILTAG_OTHER;
+
+ return $tags;
+ }
+
}
diff --git a/src/applications/ponder/xaction/PonderAnswerContentTransaction.php b/src/applications/ponder/xaction/PonderAnswerContentTransaction.php
--- a/src/applications/ponder/xaction/PonderAnswerContentTransaction.php
+++ b/src/applications/ponder/xaction/PonderAnswerContentTransaction.php
@@ -14,12 +14,29 @@
}
public function getTitle() {
+ $old = $this->getOldValue();
+
+ if (!strlen($old)) {
+ return pht(
+ '%s added an answer.',
+ $this->renderAuthor());
+ }
+
return pht(
'%s updated the answer details.',
$this->renderAuthor());
}
public function getTitleForFeed() {
+ $old = $this->getOldValue();
+
+ if (!strlen($old)) {
+ return pht(
+ '%s added %s.',
+ $this->renderAuthor(),
+ $this->renderObject());
+ }
+
return pht(
'%s updated the answer details for %s.',
$this->renderAuthor(),

File Metadata

Mime Type
text/plain
Expires
Sat, Mar 15, 9:33 AM (1 w, 10 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7575084
Default Alt Text
D18285.id43978.diff (2 KB)

Event Timeline