Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15381134
D9995.id24029.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
4 KB
Referenced Files
None
Subscribers
None
D9995.id24029.diff
View Options
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -117,7 +117,6 @@
'PhutilBootloader' => 'moduleutils/PhutilBootloader.php',
'PhutilBootloaderException' => 'moduleutils/PhutilBootloaderException.php',
'PhutilBufferedIterator' => 'utils/PhutilBufferedIterator.php',
- 'PhutilBufferedIteratorExample' => 'utils/PhutilBufferedIteratorExample.php',
'PhutilBufferedIteratorTestCase' => 'utils/__tests__/PhutilBufferedIteratorTestCase.php',
'PhutilBugtraqParser' => 'parser/PhutilBugtraqParser.php',
'PhutilBugtraqParserTestCase' => 'parser/__tests__/PhutilBugtraqParserTestCase.php',
@@ -167,6 +166,7 @@
'PhutilEventEngine' => 'events/PhutilEventEngine.php',
'PhutilEventListener' => 'events/PhutilEventListener.php',
'PhutilEventType' => 'events/constant/PhutilEventType.php',
+ 'PhutilExampleBufferedIterator' => 'utils/PhutilExampleBufferedIterator.php',
'PhutilExcessiveServiceCallsDaemon' => 'daemon/torture/PhutilExcessiveServiceCallsDaemon.php',
'PhutilExecChannel' => 'channel/PhutilExecChannel.php',
'PhutilExecPassthru' => 'future/exec/PhutilExecPassthru.php',
@@ -465,8 +465,8 @@
),
'xmap' => array(
'AASTNodeList' => array(
- 0 => 'Iterator',
- 1 => 'Countable',
+ 'Iterator',
+ 'Countable',
),
'AbstractDirectedGraphTestCase' => 'PhutilTestCase',
'AphrontDatabaseConnection' => 'PhutilQsprintfInterface',
@@ -529,10 +529,10 @@
'PhutilArgumentSpecificationTestCase' => 'PhutilTestCase',
'PhutilArgumentUsageException' => 'PhutilArgumentParserException',
'PhutilArray' => array(
- 0 => 'Phobject',
- 1 => 'Countable',
- 2 => 'ArrayAccess',
- 3 => 'Iterator',
+ 'Phobject',
+ 'Countable',
+ 'ArrayAccess',
+ 'Iterator',
),
'PhutilArrayTestCase' => 'PhutilTestCase',
'PhutilArrayWithDefaultValue' => 'PhutilArray',
@@ -559,7 +559,6 @@
'PhutilAuthUserAbortedException' => 'PhutilAuthException',
'PhutilBootloaderException' => 'Exception',
'PhutilBufferedIterator' => 'Iterator',
- 'PhutilBufferedIteratorExample' => 'PhutilBufferedIterator',
'PhutilBufferedIteratorTestCase' => 'PhutilTestCase',
'PhutilBugtraqParserTestCase' => 'PhutilTestCase',
'PhutilCLikeCodeSnippetContextFreeGrammar' => 'PhutilCodeSnippetContextFreeGrammar',
@@ -587,6 +586,7 @@
'PhutilErrorHandlerTestCase' => 'PhutilTestCase',
'PhutilErrorTrap' => 'Phobject',
'PhutilEventType' => 'PhutilEventConstants',
+ 'PhutilExampleBufferedIterator' => 'PhutilBufferedIterator',
'PhutilExcessiveServiceCallsDaemon' => 'PhutilTortureTestDaemon',
'PhutilExecChannel' => 'PhutilChannel',
'PhutilExecPassthru' => 'Phobject',
diff --git a/src/utils/PhutilBufferedIterator.php b/src/utils/PhutilBufferedIterator.php
--- a/src/utils/PhutilBufferedIterator.php
+++ b/src/utils/PhutilBufferedIterator.php
@@ -6,7 +6,7 @@
* by page and allows you to implement an iterator over a large result set
* without needing to hold the entire set in memory.
*
- * For an example implementation, see @{class:PhutilBufferedIteratorExample}.
+ * For an example implementation, see @{class:PhutilExampleBufferedIterator}.
*
* @task impl Methods to Implement
* @task config Configuration
diff --git a/src/utils/PhutilBufferedIteratorExample.php b/src/utils/PhutilExampleBufferedIterator.php
rename from src/utils/PhutilBufferedIteratorExample.php
rename to src/utils/PhutilExampleBufferedIterator.php
--- a/src/utils/PhutilBufferedIteratorExample.php
+++ b/src/utils/PhutilExampleBufferedIterator.php
@@ -3,7 +3,7 @@
/**
* Example implementation and test case for @{class:PhutilBufferedIterator}.
*/
-final class PhutilBufferedIteratorExample extends PhutilBufferedIterator {
+final class PhutilExampleBufferedIterator extends PhutilBufferedIterator {
private $cursor;
private $data;
diff --git a/src/utils/__tests__/PhutilBufferedIteratorTestCase.php b/src/utils/__tests__/PhutilBufferedIteratorTestCase.php
--- a/src/utils/__tests__/PhutilBufferedIteratorTestCase.php
+++ b/src/utils/__tests__/PhutilBufferedIteratorTestCase.php
@@ -1,14 +1,14 @@
<?php
/**
- * Test cases for @{class:PhutilBufferedIteratorExample}.
+ * Test cases for @{class:PhutilExampleBufferedIterator}.
*/
final class PhutilBufferedIteratorTestCase extends PhutilTestCase {
public function testBufferedIterator() {
$expect = array_fill(0, 23, 'example');
- $iterator = new PhutilBufferedIteratorExample();
+ $iterator = new PhutilExampleBufferedIterator();
$iterator->setPageSize(3);
$iterator->setExampleData($expect);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Mar 15, 6:05 AM (1 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7685045
Default Alt Text
D9995.id24029.diff (4 KB)
Attached To
Mode
D9995: Rename `PhutilBufferedIteratorExample` to `PhutilExampleBufferedIterator`
Attached
Detach File
Event Timeline
Log In to Comment