Page MenuHomePhabricator

D18542.diff
No OneTemporary

D18542.diff

diff --git a/src/applications/differential/storage/DifferentialTransaction.php b/src/applications/differential/storage/DifferentialTransaction.php
--- a/src/applications/differential/storage/DifferentialTransaction.php
+++ b/src/applications/differential/storage/DifferentialTransaction.php
@@ -105,6 +105,18 @@
return parent::shouldHide();
}
+ public function shouldHideForMail(array $xactions) {
+ switch ($this->getTransactionType()) {
+ case DifferentialRevisionReviewersTransaction::TRANSACTIONTYPE:
+ // Don't hide the initial "X added reviewers: ..." transaction during
+ // object creation from mail. See T12118 and PHI54.
+ return false;
+ }
+
+ return parent::shouldHideForMail($xactions);
+ }
+
+
public function isInlineCommentTransaction() {
switch ($this->getTransactionType()) {
case self::TYPE_INLINE:

File Metadata

Mime Type
text/plain
Expires
Fri, Mar 14, 7:09 PM (7 h, 35 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7564914
Default Alt Text
D18542.diff (881 B)

Event Timeline