Page MenuHomePhabricator

D18678.id44844.diff
No OneTemporary

D18678.id44844.diff

diff --git a/src/repository/api/ArcanistGitAPI.php b/src/repository/api/ArcanistGitAPI.php
--- a/src/repository/api/ArcanistGitAPI.php
+++ b/src/repository/api/ArcanistGitAPI.php
@@ -497,6 +497,10 @@
return null;
}
+ if (!strlen($branch)) {
+ return null;
+ }
+
return $branch;
}
@@ -509,7 +513,7 @@
// Verify this, and strip it.
$ref = rtrim($stdout);
$branch = $this->getBranchNameFromRef($ref);
- if (!$branch) {
+ if ($branch === null) {
throw new Exception(
pht('Failed to parse %s output!', 'git symbolic-ref'));
}
@@ -1015,7 +1019,7 @@
list($ref, $hash, $epoch, $tree, $desc, $text) = $fields;
$branch = $this->getBranchNameFromRef($ref);
- if ($branch) {
+ if ($branch !== null) {
$result[] = array(
'current' => ($branch === $current),
'name' => $branch,

File Metadata

Mime Type
text/plain
Expires
Fri, Mar 14, 4:25 AM (1 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7645503
Default Alt Text
D18678.id44844.diff (915 B)

Event Timeline