D13245.id32019.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D13245.id32019.diff
View Options

	diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
	--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
	+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
	@@ -936,14 +936,16 @@
	$object,
	$herald_xactions);

	- $adapter = $this->getHeraldAdapter();
	- $this->heraldEmailPHIDs = $adapter->getEmailPHIDs();
	- $this->heraldForcedEmailPHIDs = $adapter->getForcedEmailPHIDs();
	-
	// Merge the new transactions into the transaction list: we want to
	// send email and publish feed stories about them, too.
	$xactions = array_merge($xactions, $herald_xactions);
	}
	+
	+ // If Herald did not generate transactions, we may still need to handle
	+ // "Send an Email" rules.
	+ $adapter = $this->getHeraldAdapter();
	+ $this->heraldEmailPHIDs = $adapter->getEmailPHIDs();
	+ $this->heraldForcedEmailPHIDs = $adapter->getForcedEmailPHIDs();
	}

	$this->didApplyTransactions($xactions);