Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15368103
D8914.id21149.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D8914.id21149.diff
View Options
diff --git a/src/applications/diffusion/controller/DiffusionController.php b/src/applications/diffusion/controller/DiffusionController.php
--- a/src/applications/diffusion/controller/DiffusionController.php
+++ b/src/applications/diffusion/controller/DiffusionController.php
@@ -40,29 +40,6 @@
}
}
- public function buildApplicationPage($view, array $options) {
- if ($this->diffusionRequest) {
- $drequest = $this->getDiffusionRequest();
- $repository = $drequest->getRepository();
- $error_view = $this->buildRepositoryWarning($repository);
-
- $views = array();
- $not_inserted = true;
- foreach ($view as $view_object_or_array) {
- $views[] = $view_object_or_array;
- if ($not_inserted &&
- $view_object_or_array instanceof PhabricatorCrumbsView) {
- $views[] = $error_view;
- $not_inserted = false;
- }
- }
- } else {
- $views = $view;
- }
-
- return parent::buildApplicationPage($views, $options);
- }
-
public function buildCrumbs(array $spec = array()) {
$crumbs = $this->buildApplicationCrumbs();
$crumb_list = $this->buildCrumbList($spec);
@@ -258,23 +235,4 @@
->appendChild($body);
}
- private function buildRepositoryWarning(PhabricatorRepository $repository) {
- $error_view = null;
- $title = null;
- if ($repository->isImporting()) {
- $title = pht('This repository is still importing.');
- $body = pht('Things may not work properly until the import finishes.');
- } else if (!$repository->isTracked()) {
- $title = pht('This repository is not tracked.');
- $body = pht(
- 'Things may not work properly until tracking is enabled and '.
- 'importing finishes.');
- }
-
- if ($title) {
- $error_view = $this->renderStatusMessage($title, $body);
- }
-
- return $error_view;
- }
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Mar 12, 11:50 PM (10 h, 6 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7597689
Default Alt Text
D8914.id21149.diff (1 KB)
Attached To
Mode
D8914: Revert the global "not imported yet" warning in Diffusion until we have better support
Attached
Detach File
Event Timeline
Log In to Comment