Page MenuHomePhabricator
Files F15367591

D8285.id.diff
No OneTemporary
Actions

D8285.id.diff
View Options

Index: src/__phutil_library_map__.php
===================================================================
--- src/__phutil_library_map__.php
+++ src/__phutil_library_map__.php
@@ -465,6 +465,7 @@
'DifferentialSummaryField' => 'applications/differential/customfield/DifferentialSummaryField.php',
'DifferentialSummaryFieldSpecification' => 'applications/differential/field/specification/DifferentialSummaryFieldSpecification.php',
'DifferentialTasksAttacher' => 'applications/differential/DifferentialTasksAttacher.php',
+ 'DifferentialTestPlanField' => 'applications/differential/customfield/DifferentialTestPlanField.php',
'DifferentialTestPlanFieldSpecification' => 'applications/differential/field/specification/DifferentialTestPlanFieldSpecification.php',
'DifferentialTitleField' => 'applications/differential/customfield/DifferentialTitleField.php',
'DifferentialTitleFieldSpecification' => 'applications/differential/field/specification/DifferentialTitleFieldSpecification.php',
@@ -3008,6 +3009,7 @@
'DifferentialSubscribeController' => 'DifferentialController',
'DifferentialSummaryField' => 'DifferentialCoreCustomField',
'DifferentialSummaryFieldSpecification' => 'DifferentialFreeformFieldSpecification',
+ 'DifferentialTestPlanField' => 'DifferentialCoreCustomField',
'DifferentialTestPlanFieldSpecification' => 'DifferentialFieldSpecification',
'DifferentialTitleField' => 'DifferentialCoreCustomField',
'DifferentialTitleFieldSpecification' => 'DifferentialFreeformFieldSpecification',
Index: src/applications/differential/customfield/DifferentialCoreCustomField.php
===================================================================
--- src/applications/differential/customfield/DifferentialCoreCustomField.php
+++ src/applications/differential/customfield/DifferentialCoreCustomField.php
@@ -18,10 +18,53 @@
DifferentialRevision $revision,
$value);
- public function isCoreFieldRequired() {
+ protected function isCoreFieldRequired() {
return false;
}
+ protected function isCoreFieldValueEmpty($value) {
+ if (is_array($value)) {
+ return !$value;
+ }
+ return !strlen(trim($value));
+ }
+
+ protected function getCoreFieldRequiredErrorString() {
+ throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ }
+
+ public function validateApplicationTransactions(
+ PhabricatorApplicationTransactionEditor $editor,
+ $type,
+ array $xactions) {
+
+ $this->setFieldError(null);
+
+ $errors = parent::validateApplicationTransactions(
+ $editor,
+ $type,
+ $xactions);
+
+ $transaction = null;
+ foreach ($xactions as $xaction) {
+ $value = $xaction->getNewValue();
+ if ($this->isCoreFieldRequired()) {
+ if ($this->isCoreFieldValueEmpty($value)) {
+ $error = new PhabricatorApplicationTransactionValidationError(
+ $type,
+ pht('Required'),
+ $this->getCoreFieldRequiredErrorString(),
+ $xaction);
+ $error->setIsMissingFieldError(true);
+ $errors[] = $error;
+ $this->setFieldError(pht('Required'));
+ }
+ }
+ }
+
+ return $errors;
+ }
+
public function canDisableField() {
return false;
}
Index: src/applications/differential/customfield/DifferentialTestPlanField.php
===================================================================
--- /dev/null
+++ src/applications/differential/customfield/DifferentialTestPlanField.php
@@ -0,0 +1,95 @@
+<?php
+
+final class DifferentialTestPlanField
+ extends DifferentialCoreCustomField {
+
+ public function getFieldKey() {
+ return 'differential:test-plan';
+ }
+
+ public function getFieldName() {
+ return pht('Test Plan');
+ }
+
+ public function getFieldDescription() {
+ return pht('Actions performed to verify the behavior of the change.');
+ }
+
+ protected function readValueFromRevision(
+ DifferentialRevision $revision) {
+ return $revision->getTestPlan();
+ }
+
+ protected function writeValueToRevision(
+ DifferentialRevision $revision,
+ $value) {
+ $revision->setTestPlan($value);
+ }
+
+ protected function isCoreFieldRequired() {
+ return PhabricatorEnv::getEnvConfig('differential.require-test-plan-field');
+ }
+
+ public function canDisableField() {
+ return true;
+ }
+
+ protected function getCoreFieldRequiredErrorString() {
+ return pht(
+ 'You must provide a test plan: describe the actions you performed '.
+ 'to verify the behvaior of this change.');
+ }
+
+ public function readValueFromRequest(AphrontRequest $request) {
+ $this->setValue($request->getStr($this->getFieldKey()));
+ }
+
+ public function renderEditControl() {
+ return id(new PhabricatorRemarkupControl())
+ ->setName($this->getFieldKey())
+ ->setValue($this->getValue())
+ ->setError($this->getFieldError())
+ ->setLabel($this->getFieldName());
+ }
+
+ public function getApplicationTransactionTitle(
+ PhabricatorApplicationTransaction $xaction) {
+ $author_phid = $xaction->getAuthorPHID();
+ $old = $xaction->getOldValue();
+ $new = $xaction->getNewValue();
+
+ return pht(
+ '%s updated the test plan for this revision.',
+ $xaction->renderHandleLink($author_phid));
+ }
+
+ public function getApplicationTransactionTitleForFeed(
+ PhabricatorApplicationTransaction $xaction,
+ PhabricatorFeedStory $story) {
+
+ $object_phid = $xaction->getObjectPHID();
+ $author_phid = $xaction->getAuthorPHID();
+ $old = $xaction->getOldValue();
+ $new = $xaction->getNewValue();
+
+ return pht(
+ '%s updated the test plan for %s.',
+ $xaction->renderHandleLink($author_phid),
+ $xaction->renderHandleLink($object_phid));
+ }
+
+ public function getApplicationTransactionHasChangeDetails(
+ PhabricatorApplicationTransaction $xaction) {
+ return true;
+ }
+
+ public function getApplicationTransactionChangeDetails(
+ PhabricatorApplicationTransaction $xaction,
+ PhabricatorUser $viewer) {
+ return $xaction->renderTextCorpusChangeDetails(
+ $viewer,
+ $xaction->getOldValue(),
+ $xaction->getNewValue());
+ }
+
+}
Index: src/applications/differential/customfield/DifferentialTitleField.php
===================================================================
--- src/applications/differential/customfield/DifferentialTitleField.php
+++ src/applications/differential/customfield/DifferentialTitleField.php
@@ -26,36 +26,18 @@
$revision->setTitle($value);
}
- public function validateApplicationTransactions(
- PhabricatorApplicationTransactionEditor $editor,
- $type,
- array $xactions) {
-
- $errors = parent::validateApplicationTransactions(
- $editor,
- $type,
- $xactions);
-
- $transaction = null;
- foreach ($xactions as $xaction) {
- $value = $xaction->getNewValue();
- if (!strlen($value)) {
- $error = new PhabricatorApplicationTransactionValidationError(
- $type,
- pht('Required'),
- pht('You must choose a title for this revision.'),
- $xaction);
- $error->setIsMissingFieldError(true);
- $errors[] = $error;
- $this->setFieldError(pht('Required'));
- }
- }
+ protected function getCoreFieldRequiredErrorString() {
+ return pht('You must choose a title for this revision.');
}
public function readValueFromRequest(AphrontRequest $request) {
$this->setValue($request->getStr($this->getFieldKey()));
}
+ protected function isCoreFieldRequired() {
+ return true;
+ }
+
public function renderEditControl() {
return id(new AphrontFormTextAreaControl())
->setHeight(AphrontFormTextAreaControl::HEIGHT_VERY_SHORT)

File Metadata

Mime Type
text/plain
Expires
Wed, Mar 12, 8:02 PM (9 h, 34 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7593364
Default Alt Text
D8285.id.diff (7 KB)

Event Timeline

Phabricator · Built by Phacility