Page MenuHomePhabricator

D9909.id23793.diff
No OneTemporary

D9909.id23793.diff

diff --git a/externals/jsonlint/src/Seld/JsonLint/JsonParser.php b/externals/jsonlint/src/Seld/JsonLint/JsonParser.php
--- a/externals/jsonlint/src/Seld/JsonLint/JsonParser.php
+++ b/externals/jsonlint/src/Seld/JsonLint/JsonParser.php
@@ -165,7 +165,7 @@
$errStr = null;
while (true) {
- // retreive state number from top of stack
+ // retrieve state number from top of stack
$state = $this->stack[count($this->stack)-1];
// use default actions if available
diff --git a/scripts/__init_script__.php b/scripts/__init_script__.php
--- a/scripts/__init_script__.php
+++ b/scripts/__init_script__.php
@@ -38,7 +38,7 @@
// applied to 100+ levels of directory nesting). Stop it from triggering:
// we explicitly limit recursive algorithms which should be limited.
- // After Feb 2014, XDebug inteprets a value of 0 to mean "do not allow any
+ // After Feb 2014, XDebug interprets a value of 0 to mean "do not allow any
// function calls". Previously, 0 effectively disabled this check. For
// context, see T5027.
'xdebug.max_nesting_level' => PHP_INT_MAX,
diff --git a/scripts/daemon/torture/resist-death.php b/scripts/daemon/torture/resist-death.php
--- a/scripts/daemon/torture/resist-death.php
+++ b/scripts/daemon/torture/resist-death.php
@@ -2,7 +2,7 @@
<?php
// This script just creates a process which is difficult to terminate. It is
-// used for daemon resiliance tests.
+// used for daemon resilience tests.
declare(ticks = 1);
pcntl_signal(SIGTERM, 'ignore');
diff --git a/scripts/utils/utf8.php b/scripts/utils/utf8.php
--- a/scripts/utils/utf8.php
+++ b/scripts/utils/utf8.php
@@ -119,7 +119,7 @@
$width = strlen(max(array_keys($map)));
- // Set $last such that we print a newline on the first iteration thorugh
+ // Set $last such that we print a newline on the first iteration through
// the loop.
$last = -2;
foreach ($map as $idx => $ignored) {
diff --git a/src/cache/PhutilKeyValueCacheAPC.php b/src/cache/PhutilKeyValueCacheAPC.php
--- a/src/cache/PhutilKeyValueCacheAPC.php
+++ b/src/cache/PhutilKeyValueCacheAPC.php
@@ -30,7 +30,7 @@
public function setKeys(array $keys, $ttl = null) {
// NOTE: Although modern APC supports passing an array to `apc_store()`,
- // it is not supported by older version fo APC or by HPHP.
+ // it is not supported by older version of APC or by HPHP.
foreach ($keys as $key => $value) {
apc_store($key, $value, $ttl);
diff --git a/src/channel/PhutilChannel.php b/src/channel/PhutilChannel.php
--- a/src/channel/PhutilChannel.php
+++ b/src/channel/PhutilChannel.php
@@ -1,7 +1,7 @@
<?php
/**
- * Wrapper arounds streams, pipes, and other things that have basic read/write
+ * Wrapper around streams, pipes, and other things that have basic read/write
* I/O characteristics.
*
* Channels include buffering, so you can do fire-and-forget writes and reads
diff --git a/src/channel/PhutilExecChannel.php b/src/channel/PhutilExecChannel.php
--- a/src/channel/PhutilExecChannel.php
+++ b/src/channel/PhutilExecChannel.php
@@ -30,7 +30,7 @@
* a server but performs I/O on stdin/stdout, and you need to act like a client
* or interact with the program at the same time as you manage traditional
* socket connections. Examples are Mercurial operating in "cmdserve" mode, git
- * operating in "receive-pack" mode, etc. It is unlikely that any reasonble
+ * operating in "receive-pack" mode, etc. It is unlikely that any reasonable
* use of this class is concise enough to make a short example out of, so you
* get a contrived one instead.
*
diff --git a/src/error/PhutilOpaqueEnvelopeKey.php b/src/error/PhutilOpaqueEnvelopeKey.php
--- a/src/error/PhutilOpaqueEnvelopeKey.php
+++ b/src/error/PhutilOpaqueEnvelopeKey.php
@@ -32,7 +32,7 @@
// NOTE: We're using a weak random source because cryptographic levels
// of security aren't terribly important here and it allows us to use
// envelopes on systems which don't have a strong random source. Notably,
- // this lets us make it to the readbility check for `/dev/urandom` in
+ // this lets us make it to the readability check for `/dev/urandom` in
// Phabricator on systems where we can't read it.
self::$key = '';
for ($ii = 0; $ii < 8; $ii++) {
diff --git a/src/filesystem/Filesystem.php b/src/filesystem/Filesystem.php
--- a/src/filesystem/Filesystem.php
+++ b/src/filesystem/Filesystem.php
@@ -619,7 +619,7 @@
"Failed to create directory `{$path}'.");
}
- // Need to change premissions explicitly because mkdir does something
+ // Need to change permissions explicitly because mkdir does something
// slightly different. mkdir(2) man page:
// 'The parameter mode specifies the permissions to use. It is modified by
// the process's umask in the usual way: the permissions of the created
diff --git a/src/filesystem/linesofalarge/LinesOfALarge.php b/src/filesystem/linesofalarge/LinesOfALarge.php
--- a/src/filesystem/linesofalarge/LinesOfALarge.php
+++ b/src/filesystem/linesofalarge/LinesOfALarge.php
@@ -11,7 +11,7 @@
* simpler) to read the entire stream first and then process it (e.g., with
* `explode()`).
*
- * This class is abstract. The concrete implementations avialable are:
+ * This class is abstract. The concrete implementations available are:
*
* - @{class:LinesOfALargeFile}, for reading large files; and
* - @{class:LinesOfALargeExecFuture}, for reading large output from
@@ -24,7 +24,7 @@
* }
*
* By default, a line is delimited by "\n". The delimiting character is
- * not returned. You can change the charater with @{method:setDelimiter}. The
+ * not returned. You can change the character with @{method:setDelimiter}. The
* last part of the file is returned as the last $line, even if it does not
* include a terminating character (if it does, the terminating character is
* stripped).
@@ -192,7 +192,7 @@
// No more bytes. If we have a buffer, return its contents. We
// potentially return part of a line here if the last line had no
// delimiter, but that currently seems reasonable as a default
- // behaivor. If we don't have a buffer, we're done.
+ // behavior. If we don't have a buffer, we're done.
$this->eof = true;
if (strlen($this->buf)) {
$this->num++;
diff --git a/src/future/exec/ExecFuture.php b/src/future/exec/ExecFuture.php
--- a/src/future/exec/ExecFuture.php
+++ b/src/future/exec/ExecFuture.php
@@ -595,7 +595,7 @@
*/
public function isReady() {
// NOTE: We have soft dependencies on PhutilServiceProfiler and
- // PhutilErrorTrap here. These depencies are soft to avoid the need to
+ // PhutilErrorTrap here. These dependencies are soft to avoid the need to
// build them into the Phage agent. Under normal circumstances, these
// classes are always available.
@@ -612,7 +612,7 @@
}
if (!$this->start) {
- // We might already have started the timer via initating resolution.
+ // We might already have started the timer via initiating resolution.
$this->start = microtime(true);
}
@@ -627,7 +627,7 @@
// See T4395. proc_open under Windows uses "cmd /C [cmd]", which will
// strip the first and last quote when there aren't exactly two quotes
// (and some other conditions as well). This results in a command that
- // looks like `command" "path to my file" "something someting` which is
+ // looks like `command" "path to my file" "something something` which is
// clearly wrong. By surrounding the command string with quotes we can
// be sure this process is harmless.
if (strpos($unmasked_command, '"') !== false) {
diff --git a/src/future/exec/__tests__/ExecFutureTestCase.php b/src/future/exec/__tests__/ExecFutureTestCase.php
--- a/src/future/exec/__tests__/ExecFutureTestCase.php
+++ b/src/future/exec/__tests__/ExecFutureTestCase.php
@@ -12,7 +12,7 @@
}
public function testKeepPipe() {
- // NOTE: This is mosty testing the semantics of $keep_pipe in write().
+ // NOTE: This is mostly testing the semantics of $keep_pipe in write().
list($stdout) = id(new ExecFuture('cat'))
->write('', true)
diff --git a/src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupListBlockRule.php b/src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupListBlockRule.php
--- a/src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupListBlockRule.php
+++ b/src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupListBlockRule.php
@@ -260,7 +260,7 @@
// We may need to open a list on a <null> node, but they do not have
- // list style information yet. We need to propagate list style inforamtion
+ // list style information yet. We need to propagate list style information
// backward through the tree. In the above example, the tree now looks
// like this:
//
diff --git a/src/parser/aast/api/AASTNode.php b/src/parser/aast/api/AASTNode.php
--- a/src/parser/aast/api/AASTNode.php
+++ b/src/parser/aast/api/AASTNode.php
@@ -116,7 +116,7 @@
* Build a cache to improve the performance of @{method:selectTokensOfType}.
* This cache makes a time/memory tradeoff by aggressively caching token
* types. It may improve the tree's query performance substantially if you
- * make a large number of queries, but also requires a signficant amount of
+ * make a large number of queries, but also requires a significant amount of
* memory.
*
* This builds a cache for this node only.
diff --git a/src/parser/argument/PhutilArgumentParser.php b/src/parser/argument/PhutilArgumentParser.php
--- a/src/parser/argument/PhutilArgumentParser.php
+++ b/src/parser/argument/PhutilArgumentParser.php
@@ -102,7 +102,7 @@
/**
* Parse and consume a list of arguments, removing them from the argument
* vector but leaving unparsed arguments for later consumption. You can
- * retreive unconsumed arguments directly with
+ * retrieve unconsumed arguments directly with
* @{method:getUnconsumedArgumentVector}. Doing a partial parse can make it
* easier to share common flags across scripts or workflows.
*
diff --git a/src/phage/bootloader/PhagePHPAgentBootloader.php b/src/phage/bootloader/PhagePHPAgentBootloader.php
--- a/src/phage/bootloader/PhagePHPAgentBootloader.php
+++ b/src/phage/bootloader/PhagePHPAgentBootloader.php
@@ -15,7 +15,7 @@
$len = $this->bootLength;
// We need to run a command which will bootload a full agent by reading
- // and evaulating source code from stdin. This is the smallest bootstrap
+ // and evaluating source code from stdin. This is the smallest bootstrap
// I was able to construct:
//
// - Using `fread(STDIN, ...)` is only good up to 8192 bytes.
diff --git a/src/symbols/PhutilSymbolLoader.php b/src/symbols/PhutilSymbolLoader.php
--- a/src/symbols/PhutilSymbolLoader.php
+++ b/src/symbols/PhutilSymbolLoader.php
@@ -26,7 +26,7 @@
* The **library** and **where** keys show where the symbol is defined. The
* **type** and **name** keys identify the symbol itself.
*
- * NOTE: This class must not use libphutil funtions, including id() and idx().
+ * NOTE: This class must not use libphutil functions, including id() and idx().
*
* @task config Configuring the Query
* @task load Loading Symbols
diff --git a/src/utils/PhutilUTF8StringTruncator.php b/src/utils/PhutilUTF8StringTruncator.php
--- a/src/utils/PhutilUTF8StringTruncator.php
+++ b/src/utils/PhutilUTF8StringTruncator.php
@@ -187,7 +187,7 @@
// NOTE: This is not complete, and there are many other word boundary
// characters and reasonable places to break words in the UTF-8 character
- // space. For now, this gives us reasonable behavior for latin langauges. We
+ // space. For now, this gives us reasonable behavior for latin languages. We
// don't necessarily have access to PCRE+Unicode so there isn't a great way
// for us to look up character attributes.
diff --git a/src/utils/utf8.php b/src/utils/utf8.php
--- a/src/utils/utf8.php
+++ b/src/utils/utf8.php
@@ -473,7 +473,7 @@
}
/**
- * Hard-wrap a block of UTF-8 text with no embedded HTML tags and entitites
+ * Hard-wrap a block of UTF-8 text with no embedded HTML tags and entities.
*
* @param string A non HTML string
* @param int Width of the hard-wrapped lines
@@ -526,7 +526,7 @@
*
* @param string String to re-encode.
* @param string Target encoding name, like "UTF-8".
- * @param string Source endocing name, like "ISO-8859-1".
+ * @param string Source encoding name, like "ISO-8859-1".
* @return string Input string, with converted character encoding.
*
* @phutil-external-symbol function mb_convert_encoding
diff --git a/src/utils/utils.php b/src/utils/utils.php
--- a/src/utils/utils.php
+++ b/src/utils/utils.php
@@ -398,7 +398,7 @@
/**
* Filter a list of objects by executing a method across all the objects and
- * filter out the ones wth empty() results. this function works just like
+ * filter out the ones with empty() results. this function works just like
* @{function:ifilter}, except that it operates on a list of objects instead
* of a list of arrays.
*
diff --git a/src/xsprintf/qsprintf.php b/src/xsprintf/qsprintf.php
--- a/src/xsprintf/qsprintf.php
+++ b/src/xsprintf/qsprintf.php
@@ -41,7 +41,7 @@
* %~ ("Substring")
* Escapes a substring query for a LIKE (or NOT LIKE) clause. For example:
*
- * // Find all rows with $search as a substing of `name`.
+ * // Find all rows with $search as a substring of `name`.
* qsprintf($escaper, 'WHERE name LIKE %~', $search);
*
* See also %> and %<.

File Metadata

Mime Type
text/plain
Expires
Wed, Mar 12, 8:01 PM (2 h, 52 m ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7330145
Default Alt Text
D9909.id23793.diff (13 KB)

Event Timeline