Page MenuHomePhabricator
Files F15367493

D12780.diff
No OneTemporary
Actions

D12780.diff
View Options

diff --git a/src/applications/conpherence/query/ConpherenceThreadQuery.php b/src/applications/conpherence/query/ConpherenceThreadQuery.php
--- a/src/applications/conpherence/query/ConpherenceThreadQuery.php
+++ b/src/applications/conpherence/query/ConpherenceThreadQuery.php
@@ -285,10 +285,9 @@
$conpherence->$method();
}
$flat_phids = array_mergev($handle_phids);
- $handles = id(new PhabricatorHandleQuery())
- ->setViewer($this->getViewer())
- ->withPHIDs($flat_phids)
- ->execute();
+ $viewer = $this->getViewer();
+ $handles = $viewer->loadHandles($flat_phids);
+ $handles = iterator_to_array($handles);
foreach ($handle_phids as $conpherence_phid => $phids) {
$conpherence = $conpherences[$conpherence_phid];
$conpherence->attachHandles(
diff --git a/src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php b/src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php
--- a/src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php
+++ b/src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php
@@ -126,10 +126,8 @@
$handles = array();
$merged = array_mergev($phids);
if ($merged) {
- $handles = id(new PhabricatorHandleQuery())
- ->setViewer($this->getViewer())
- ->withPHIDs($merged)
- ->execute();
+ $handles = $this->getViewer()->loadHandles($merged);
+ $handles = iterator_to_array($handles);
}
foreach ($xactions as $xaction) {
$xaction->setHandles(
diff --git a/src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php b/src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php
--- a/src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php
+++ b/src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php
@@ -28,10 +28,9 @@
protected function loadHandles(array $objects) {
$phids = mpull($objects, 'getPHID');
- $handles = id(new PhabricatorHandleQuery($phids))
- ->withPHIDs($phids)
- ->setViewer($this->getEngine()->getConfig('viewer'))
- ->execute();
+ $viewer = $this->getEngine()->getConfig('viewer');
+ $handles = $viewer->loadHandles($phids);
+ $handles = iterator_to_array($handles);
$result = array();
foreach ($objects as $id => $object) {

File Metadata

Mime Type
text/plain
Expires
Mar 12 2025, 6:53 PM (6 w, 15 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7382159
Default Alt Text
D12780.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility