D7488.id16873.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D7488.id16873.diff
View Options

	Index: src/applications/config/check/PhabricatorSetupCheckBinaries.php
	===================================================================
	--- src/applications/config/check/PhabricatorSetupCheckBinaries.php
	+++ src/applications/config/check/PhabricatorSetupCheckBinaries.php
	@@ -94,6 +94,32 @@
	}
	}

	+ $table = new PhabricatorRepository();
	+ $vcses = queryfx_all(
	+ $table->establishConnection('r'),
	+ 'SELECT DISTINCT versionControlSystem FROM %T',
	+ $table->getTableName());
	+
	+ foreach ($vcses as $vcs) {
	+ switch ($vcs['versionControlSystem']) {
	+ case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
	+ if (!Filesystem::binaryExists('git-http-backend')) {
	+ $message = pht(
	+ "On some systems, this binary lives in '/usr/lib/git' or ".
	+ "a folder that is not on the standard path. Without this ".
	+ "binary, you will not be able to serve Git repositories ".
	+ "over HTTP.");
	+ $this->raiseWarning('git-http-backend', $message);
	+ }
	+ break;
	+ case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
	+ break;
	+ case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL:
	+ break;
	+ default:
	+ break;
	+ }
	+ }
	}

	private function raiseWarning($bin, $message) {
	@@ -122,7 +148,7 @@
	->setName(pht("Missing '%s' Binary", $bin))
	->setSummary(
	pht("The '%s' binary could not be located or executed.", $bin))
	- ->setMessage($preamble.' '.$message)
	+ ->setMessage($preamble."\n\n".$message)
	->addPhabricatorConfig('environment.append-paths');
	}