Page MenuHomePhabricator
Files F15355751

D14808.id35797.diff
No OneTemporary
Actions

D14808.id35797.diff
View Options

diff --git a/src/applications/maniphest/editor/ManiphestEditEngine.php b/src/applications/maniphest/editor/ManiphestEditEngine.php
--- a/src/applications/maniphest/editor/ManiphestEditEngine.php
+++ b/src/applications/maniphest/editor/ManiphestEditEngine.php
@@ -9,6 +9,14 @@
return pht('Maniphest Tasks');
}
+ public function getSummaryHeader() {
+ return pht('Configure Maniphest Task Forms');
+ }
+
+ public function getSummaryText() {
+ return pht('Configure how users create and edit tasks.');
+ }
+
public function getEngineApplicationClass() {
return 'PhabricatorManiphestApplication';
}
diff --git a/src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php b/src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php
--- a/src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php
+++ b/src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php
@@ -9,6 +9,14 @@
return pht('Owners Packages');
}
+ public function getSummaryHeader() {
+ return pht('Configure Owners Package Forms');
+ }
+
+ public function getSummaryText() {
+ return pht('Configure forms for creating and editing packages in Owners.');
+ }
+
public function getEngineApplicationClass() {
return 'PhabricatorOwnersApplication';
}
diff --git a/src/applications/paste/editor/PhabricatorPasteEditEngine.php b/src/applications/paste/editor/PhabricatorPasteEditEngine.php
--- a/src/applications/paste/editor/PhabricatorPasteEditEngine.php
+++ b/src/applications/paste/editor/PhabricatorPasteEditEngine.php
@@ -9,6 +9,14 @@
return pht('Pastes');
}
+ public function getSummaryHeader() {
+ return pht('Configure Paste Forms');
+ }
+
+ public function getSummaryText() {
+ return pht('Configure creation and editing forms in Paste.');
+ }
+
public function getEngineApplicationClass() {
return 'PhabricatorPasteApplication';
}
diff --git a/src/applications/phame/editor/PhameBlogEditEngine.php b/src/applications/phame/editor/PhameBlogEditEngine.php
--- a/src/applications/phame/editor/PhameBlogEditEngine.php
+++ b/src/applications/phame/editor/PhameBlogEditEngine.php
@@ -13,6 +13,14 @@
return 'PhabricatorPhameApplication';
}
+ public function getSummaryHeader() {
+ return pht('Configure Phame Blog Forms');
+ }
+
+ public function getSummaryText() {
+ return pht('Configure how blogs in Phame are created and edited.');
+ }
+
protected function newEditableObject() {
return PhameBlog::initializeNewBlog($this->getViewer());
}
diff --git a/src/applications/transactions/editengine/PhabricatorEditEngine.php b/src/applications/transactions/editengine/PhabricatorEditEngine.php
--- a/src/applications/transactions/editengine/PhabricatorEditEngine.php
+++ b/src/applications/transactions/editengine/PhabricatorEditEngine.php
@@ -225,6 +225,27 @@
}
+ /**
+ * Return a human-readable header describing what this engine is used to do,
+ * like "Configure Maniphest Task Forms".
+ *
+ * @return string Human-readable description of the engine.
+ * @task text
+ */
+ abstract public function getSummaryHeader();
+
+
+ /**
+ * Return a human-readable summary of what this engine is used to do.
+ *
+ * @return string Human-readable description of the engine.
+ * @task text
+ */
+ abstract public function getSummaryText();
+
+
+
+
/* -( Edit Engine Configuration )------------------------------------------ */
@@ -1010,9 +1031,9 @@
$action_button = id(new PHUIButtonView())
->setTag('a')
- ->setText(pht('Actions'))
+ ->setText(pht('Configure Form'))
->setHref('#')
- ->setIconFont('fa-bars')
+ ->setIconFont('fa-gear')
->setDropdownMenu($action_view);
return $action_button;
diff --git a/src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditEngine.php b/src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditEngine.php
--- a/src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditEngine.php
+++ b/src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditEngine.php
@@ -30,6 +30,16 @@
return pht('Edit Configurations');
}
+ public function getSummaryHeader() {
+ return pht('Configure Forms for Configuring Forms');
+ }
+
+ public function getSummaryText() {
+ return pht(
+ 'Change how forms in other applications are created and edited. '.
+ 'Advanced!');
+ }
+
public function getEngineApplicationClass() {
return 'PhabricatorTransactionsApplication';
}
diff --git a/src/applications/transactions/query/PhabricatorEditEngineSearchEngine.php b/src/applications/transactions/query/PhabricatorEditEngineSearchEngine.php
--- a/src/applications/transactions/query/PhabricatorEditEngineSearchEngine.php
+++ b/src/applications/transactions/query/PhabricatorEditEngineSearchEngine.php
@@ -65,9 +65,14 @@
$engine_key = $engine->getEngineKey();
$query_uri = "/transactions/editengine/{$engine_key}/";
+ $application = $engine->getApplication();
+ $app_icon = $application->getFontIcon();
+
$item = id(new PHUIObjectItemView())
- ->setHeader($engine->getEngineName())
- ->setHref($query_uri);
+ ->setHeader($engine->getSummaryHeader())
+ ->setHref($query_uri)
+ ->setStatusIcon($app_icon)
+ ->addAttribute($engine->getSummaryText());
$list->addItem($item);
}

File Metadata

Mime Type
text/plain
Expires
Wed, Mar 12, 6:00 AM (1 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7577019
Default Alt Text
D14808.id35797.diff (5 KB)

Event Timeline

Phabricator · Built by Phacility