D14783.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D14783.diff
View Options

	diff --git a/src/applications/transactions/controller/PhabricatorEditEngineController.php b/src/applications/transactions/controller/PhabricatorEditEngineController.php
	--- a/src/applications/transactions/controller/PhabricatorEditEngineController.php
	+++ b/src/applications/transactions/controller/PhabricatorEditEngineController.php
	@@ -70,13 +70,6 @@
	->executeOne();
	if ($config) {
	$engine = $config->getEngine();
	-
	- // TODO: When we're editing the meta-engine, we need to set the engine
	- // itself as its own target. This is hacky and it would be nice to find
	- // a cleaner approach later.
	- if ($engine instanceof PhabricatorEditEngineConfigurationEditEngine) {
	- $engine->setTargetEngine($engine);
	- }
	}

	return $config;
	diff --git a/src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditEngine.php b/src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditEngine.php
	--- a/src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditEngine.php
	+++ b/src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditEngine.php
	@@ -14,7 +14,8 @@

	public function getTargetEngine() {
	if (!$this->targetEngine) {
	- throw new PhutilInvalidStateException('setTargetEngine');
	+ // If we don't have a target engine, assume we're editing ourselves.
	+ return new PhabricatorEditEngineConfigurationEditEngine();
	}
	return $this->targetEngine;
	}