Page MenuHomePhabricator
Files F15353510

D14778.id35739.diff
No OneTemporary
Actions

D14778.id35739.diff
View Options

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -228,7 +228,6 @@
'ConduitCallTestCase' => 'applications/conduit/call/__tests__/ConduitCallTestCase.php',
'ConduitConnectConduitAPIMethod' => 'applications/conduit/method/ConduitConnectConduitAPIMethod.php',
'ConduitConnectionGarbageCollector' => 'applications/conduit/garbagecollector/ConduitConnectionGarbageCollector.php',
- 'ConduitDeprecatedCallSetupCheck' => 'applications/conduit/check/ConduitDeprecatedCallSetupCheck.php',
'ConduitEpochParameterType' => 'applications/conduit/parametertype/ConduitEpochParameterType.php',
'ConduitException' => 'applications/conduit/protocol/exception/ConduitException.php',
'ConduitGetCapabilitiesConduitAPIMethod' => 'applications/conduit/method/ConduitGetCapabilitiesConduitAPIMethod.php',
@@ -4090,7 +4089,6 @@
'ConduitCallTestCase' => 'PhabricatorTestCase',
'ConduitConnectConduitAPIMethod' => 'ConduitAPIMethod',
'ConduitConnectionGarbageCollector' => 'PhabricatorGarbageCollector',
- 'ConduitDeprecatedCallSetupCheck' => 'PhabricatorSetupCheck',
'ConduitEpochParameterType' => 'ConduitListParameterType',
'ConduitException' => 'Exception',
'ConduitGetCapabilitiesConduitAPIMethod' => 'ConduitAPIMethod',
diff --git a/src/applications/conduit/check/ConduitDeprecatedCallSetupCheck.php b/src/applications/conduit/check/ConduitDeprecatedCallSetupCheck.php
deleted file mode 100644
--- a/src/applications/conduit/check/ConduitDeprecatedCallSetupCheck.php
+++ /dev/null
@@ -1,65 +0,0 @@
-<?php
-
-final class ConduitDeprecatedCallSetupCheck extends PhabricatorSetupCheck {
-
- protected function executeChecks() {
- $methods = id(new PhabricatorConduitMethodQuery())
- ->setViewer(PhabricatorUser::getOmnipotentUser())
- ->withIsDeprecated(true)
- ->execute();
- if (!$methods) {
- return;
- }
-
- $methods = mpull($methods, null, 'getAPIMethodName');
- $method_names = mpull($methods, 'getAPIMethodName');
-
- $table = new PhabricatorConduitMethodCallLog();
- $conn_r = $table->establishConnection('r');
-
- $calls = queryfx_all(
- $conn_r,
- 'SELECT DISTINCT method FROM %T WHERE dateCreated > %d
- AND method IN (%Ls)',
- $table->getTableName(),
- time() - (60 * 60 * 24 * 30),
- $method_names);
- $calls = ipull($calls, 'method', 'method');
-
- foreach ($calls as $method_name) {
- $method = $methods[$method_name];
-
- $summary = pht(
- 'Deprecated Conduit method `%s` was called in the last 30 days. '.
- 'You should migrate away from use of this method: it will be '.
- 'removed in a future version of Phabricator.',
- $method_name);
-
- $uri = PhabricatorEnv::getURI('/conduit/log/?methods='.$method_name);
-
- $description = $method->getMethodStatusDescription();
-
- $message = pht(
- 'Deprecated Conduit method %s was called in the last 30 days. '.
- 'You should migrate away from use of this method: it will be '.
- 'removed in a future version of Phabricator.'.
- "\n\n".
- "%s: %s".
- "\n\n".
- 'If you have already migrated all callers away from this method, '.
- 'you can safely ignore this setup issue.',
- phutil_tag('tt', array(), $method_name),
- phutil_tag('tt', array(), $method_name),
- $description);
-
- $this
- ->newIssue('conduit.deprecated.'.$method_name)
- ->setShortName(pht('Deprecated Conduit Method'))
- ->setName(pht('Deprecated Conduit Method "%s" In Use', $method_name))
- ->setSummary($summary)
- ->setMessage($message)
- ->addLink($uri, pht('View Method Call Logs'));
- }
- }
-
-}

File Metadata

Mime Type
text/plain
Expires
Mar 11 2025, 10:30 PM (6 w, 21 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7383203
Default Alt Text
D14778.id35739.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility