Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15352964
D18529.id44539.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D18529.id44539.diff
View Options
diff --git a/src/applications/differential/controller/DifferentialDiffCreateController.php b/src/applications/differential/controller/DifferentialDiffCreateController.php
--- a/src/applications/differential/controller/DifferentialDiffCreateController.php
+++ b/src/applications/differential/controller/DifferentialDiffCreateController.php
@@ -182,10 +182,10 @@
->setValue($button));
$form_box = id(new PHUIObjectBoxView())
- ->setHeaderText(pht('Diff'))
+ ->setHeaderText($title)
->setValidationException($validation_exception)
->setForm($form)
- ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
+ ->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
->setFormErrors($errors);
$crumbs = $this->buildApplicationCrumbs();
@@ -197,15 +197,10 @@
$crumbs->addTextCrumb($title);
$crumbs->setBorder(true);
- $header = id(new PHUIHeaderView())
- ->setHeader($title)
- ->setHeaderIcon($header_icon);
-
$view = id(new PHUITwoColumnView())
- ->setHeader($header)
->setFooter(array(
- $info_view,
$form_box,
+ $info_view,
));
return $this->newPage()
diff --git a/src/view/phui/PHUIInfoView.php b/src/view/phui/PHUIInfoView.php
--- a/src/view/phui/PHUIInfoView.php
+++ b/src/view/phui/PHUIInfoView.php
@@ -59,6 +59,7 @@
} else {
$icon = id(new PHUIIconView())
->setIcon($icon);
+ $this->icon = $icon;
}
return $this;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Mar 11, 7:15 PM (20 h, 41 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7546970
Default Alt Text
D18529.id44539.diff (1 KB)
Attached To
Mode
D18529: Update Create Diff page for new Edit UI
Attached
Detach File
Event Timeline
Log In to Comment