Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15345173
D17075.id41065.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D17075.id41065.diff
View Options
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -445,7 +445,6 @@
'DifferentialGetWorkingCopy' => 'applications/differential/DifferentialGetWorkingCopy.php',
'DifferentialGitHubLandingStrategy' => 'applications/differential/landing/DifferentialGitHubLandingStrategy.php',
'DifferentialGitSVNIDCommitMessageField' => 'applications/differential/field/DifferentialGitSVNIDCommitMessageField.php',
- 'DifferentialGitSVNIDField' => 'applications/differential/customfield/DifferentialGitSVNIDField.php',
'DifferentialHarbormasterField' => 'applications/differential/customfield/DifferentialHarbormasterField.php',
'DifferentialHiddenComment' => 'applications/differential/storage/DifferentialHiddenComment.php',
'DifferentialHostField' => 'applications/differential/customfield/DifferentialHostField.php',
@@ -5091,7 +5090,6 @@
'DifferentialGetWorkingCopy' => 'Phobject',
'DifferentialGitHubLandingStrategy' => 'DifferentialLandingStrategy',
'DifferentialGitSVNIDCommitMessageField' => 'DifferentialCommitMessageField',
- 'DifferentialGitSVNIDField' => 'DifferentialCustomField',
'DifferentialHarbormasterField' => 'DifferentialCustomField',
'DifferentialHiddenComment' => 'DifferentialDAO',
'DifferentialHostField' => 'DifferentialCustomField',
diff --git a/src/applications/differential/customfield/DifferentialGitSVNIDField.php b/src/applications/differential/customfield/DifferentialGitSVNIDField.php
deleted file mode 100644
--- a/src/applications/differential/customfield/DifferentialGitSVNIDField.php
+++ /dev/null
@@ -1,45 +0,0 @@
-<?php
-
-/**
- * This field doesn't do anything, it just parses the "git-svn-id" field which
- * `git svn` inserts into commit messages so that we don't end up mangling
- * some other field.
- */
-final class DifferentialGitSVNIDField
- extends DifferentialCustomField {
-
- public function getFieldKey() {
- return 'differential:git-svn-id';
- }
-
- public function getFieldKeyForConduit() {
- return 'gitSVNID';
- }
-
- public function getFieldName() {
- return pht('git-svn-id');
- }
-
- public function getFieldDescription() {
- return pht(
- 'Parses the "%s" field which Git/SVN can inject into commit messages.',
- 'git-svn-id');
- }
-
- public function canDisableField() {
- return false;
- }
-
- public function shouldAppearInCommitMessage() {
- return true;
- }
-
- public function shouldAllowEditInCommitMessage() {
- return false;
- }
-
- public function renderCommitMessageValue(array $handles) {
- return null;
- }
-
-}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Mar 11, 8:54 AM (16 h, 6 m ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7309091
Default Alt Text
D17075.id41065.diff (2 KB)
Attached To
Mode
D17075: Remove "DifferentialGitSVNIDField" custom field in Differential
Attached
Detach File
Event Timeline
Log In to Comment