Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15344721
D18918.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
3 KB
Referenced Files
None
Subscribers
None
D18918.diff
View Options
diff --git a/src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php b/src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php
--- a/src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php
+++ b/src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php
@@ -11,63 +11,40 @@
return 'PhabricatorDiffusionApplication';
}
- public function buildSavedQueryFromRequest(AphrontRequest $request) {
- $saved = new PhabricatorSavedQuery();
-
- $saved->setParameter(
- 'repositoryPHIDs',
- $this->readPHIDsFromRequest(
- $request,
- 'repositories',
- array(
- PhabricatorRepositoryRepositoryPHIDType::TYPECONST,
- )));
-
- $saved->setParameter(
- 'pusherPHIDs',
- $this->readUsersFromRequest(
- $request,
- 'pushers'));
-
- return $saved;
+ public function newQuery() {
+ return new PhabricatorRepositoryPushLogQuery();
}
- public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) {
- $query = id(new PhabricatorRepositoryPushLogQuery());
+ protected function buildQueryFromParameters(array $map) {
+ $query = $this->newQuery();
- $repository_phids = $saved->getParameter('repositoryPHIDs');
- if ($repository_phids) {
- $query->withRepositoryPHIDs($repository_phids);
+ if ($map['repositoryPHIDs']) {
+ $query->withRepositoryPHIDs($map['repositoryPHIDs']);
}
- $pusher_phids = $saved->getParameter('pusherPHIDs');
- if ($pusher_phids) {
- $query->withPusherPHIDs($pusher_phids);
+ if ($map['pusherPHIDs']) {
+ $query->withPusherPHIDs($map['pusherPHIDs']);
}
return $query;
}
- public function buildSearchForm(
- AphrontFormView $form,
- PhabricatorSavedQuery $saved_query) {
-
- $repository_phids = $saved_query->getParameter('repositoryPHIDs', array());
- $pusher_phids = $saved_query->getParameter('pusherPHIDs', array());
-
- $form
- ->appendControl(
- id(new AphrontFormTokenizerControl())
- ->setDatasource(new DiffusionRepositoryDatasource())
- ->setName('repositories')
- ->setLabel(pht('Repositories'))
- ->setValue($repository_phids))
- ->appendControl(
- id(new AphrontFormTokenizerControl())
- ->setDatasource(new PhabricatorPeopleDatasource())
- ->setName('pushers')
- ->setLabel(pht('Pushers'))
- ->setValue($pusher_phids));
+ protected function buildCustomSearchFields() {
+ return array(
+ id(new PhabricatorSearchDatasourceField())
+ ->setDatasource(new DiffusionRepositoryDatasource())
+ ->setKey('repositoryPHIDs')
+ ->setAliases(array('repository', 'repositories', 'repositoryPHID'))
+ ->setLabel(pht('Repositories'))
+ ->setDescription(
+ pht('Search for pull logs for specific repositories.')),
+ id(new PhabricatorUsersSearchField())
+ ->setKey('pusherPHIDs')
+ ->setAliases(array('pusher', 'pushers', 'pusherPHID'))
+ ->setLabel(pht('Pushers'))
+ ->setDescription(
+ pht('Search for pull logs by specific users.')),
+ );
}
protected function getURI($path) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Mar 11, 6:29 AM (1 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7222204
Default Alt Text
D18918.diff (3 KB)
Attached To
Mode
D18918: Modernize "PhabricatorRepositoryPushLogSearchEngine"
Attached
Detach File
Event Timeline
Log In to Comment