Page MenuHomePhabricator

D10789.id26068.diff
No OneTemporary

D10789.id26068.diff

diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php
--- a/src/applications/differential/controller/DifferentialRevisionViewController.php
+++ b/src/applications/differential/controller/DifferentialRevisionViewController.php
@@ -24,6 +24,7 @@
->needRelationships(true)
->needReviewerStatus(true)
->needReviewerAuthority(true)
+ ->needDrafts(true)
->executeOne();
if (!$revision) {
@@ -962,6 +963,10 @@
}
}
+ if ($revision->getDrafts($this->getViewer())) {
+ $warnings[] = pht('You have unsubmitted comments on this revision.');
+ }
+
return $warnings;
}
diff --git a/src/applications/differential/view/DifferentialRevisionListView.php b/src/applications/differential/view/DifferentialRevisionListView.php
--- a/src/applications/differential/view/DifferentialRevisionListView.php
+++ b/src/applications/differential/view/DifferentialRevisionListView.php
@@ -127,7 +127,7 @@
if (isset($icons['draft'])) {
$draft = id(new PHUIIconView())
- ->setIconFont('fa-comment-o lightgreytext')
+ ->setIconFont('fa-comment yellow')
->addSigil('has-tooltip')
->setMetadata(
array(

File Metadata

Mime Type
text/plain
Expires
Mar 10 2025, 9:39 PM (8 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7474680
Default Alt Text
D10789.id26068.diff (1 KB)

Event Timeline