D19047.id45671.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D19047.id45671.diff
View Options

	diff --git a/src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php b/src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php
	--- a/src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php
	+++ b/src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php
	@@ -22,6 +22,7 @@
	protected function defineParamTypes() {
	return array(
	'objectIdentifier' => 'phid\|string',
	+ 'constraints' => 'map<string, wild>',
	) + $this->getPagerParamTypes();
	}

	@@ -66,10 +67,23 @@
	$xaction_query = PhabricatorApplicationTransactionQuery::newQueryForObject(
	$object);

	- $xactions = $xaction_query
	+ $xaction_query
	->withObjectPHIDs(array($object->getPHID()))
	- ->setViewer($viewer)
	- ->executeWithCursorPager($pager);
	+ ->setViewer($viewer);
	+
	+ $constraints = $request->getValue('constraints', array());
	+ PhutilTypeSpec::checkMap(
	+ $constraints,
	+ array(
	+ 'phids' => 'optional list<string>',
	+ ));
	+
	+ $with_phids = idx($constraints, 'phids');
	+ if ($with_phids) {
	+ $xaction_query->withPHIDs($with_phids);
	+ }
	+
	+ $xactions = $xaction_query->executeWithCursorPager($pager);

	if ($xactions) {
	$template = head($xactions)->getApplicationTransactionCommentObject();