Page MenuHomePhabricator

D8078.diff
No OneTemporary

D8078.diff

Index: src/repository/api/ArcanistMercurialAPI.php
===================================================================
--- src/repository/api/ArcanistMercurialAPI.php
+++ src/repository/api/ArcanistMercurialAPI.php
@@ -323,14 +323,16 @@
$this->getBaseCommit(),
$path);
+ $lines = phutil_split_lines($stdout, $retain_line_endings = true);
+
$blame = array();
- foreach (explode("\n", trim($stdout)) as $line) {
+ foreach ($lines as $line) {
if (!strlen($line)) {
continue;
}
$matches = null;
- $ok = preg_match('/^\s*([^:]+?) [a-f0-9]{12}: (.*)$/', $line, $matches);
+ $ok = preg_match('/^\s*([^:]+?) ([a-f0-9]{12}):/', $line, $matches);
if (!$ok) {
throw new Exception("Unable to parse Mercurial blame line: {$line}");

File Metadata

Mime Type
text/plain
Expires
Mon, Mar 10, 5:21 AM (1 h, 1 m ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7402975
Default Alt Text
D8078.diff (809 B)

Event Timeline