Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15337013
D15270.id36846.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D15270.id36846.diff
View Options
diff --git a/src/applications/project/controller/PhabricatorProjectBoardViewController.php b/src/applications/project/controller/PhabricatorProjectBoardViewController.php
--- a/src/applications/project/controller/PhabricatorProjectBoardViewController.php
+++ b/src/applications/project/controller/PhabricatorProjectBoardViewController.php
@@ -692,7 +692,7 @@
->setName(pht('Add Column'))
->setHref($add_uri)
->setDisabled(!$can_edit)
- ->setWorkflow(!$can_edit);
+ ->setWorkflow(true);
$manage_items[] = id(new PhabricatorActionView())
->setIcon('fa-exchange')
diff --git a/src/applications/project/controller/PhabricatorProjectColumnEditController.php b/src/applications/project/controller/PhabricatorProjectColumnEditController.php
--- a/src/applications/project/controller/PhabricatorProjectColumnEditController.php
+++ b/src/applications/project/controller/PhabricatorProjectColumnEditController.php
@@ -136,21 +136,13 @@
$submit = pht('Save Column');
}
- $form->appendChild(
- id(new AphrontFormSubmitControl())
- ->setValue($submit)
- ->addCancelButton($view_uri));
-
- $form_box = id(new PHUIObjectBoxView())
- ->setHeaderText($title)
+ return $this->newDialog()
+ ->setWidth(AphrontDialogView::WIDTH_FORM)
+ ->setTitle($title)
+ ->appendForm($form)
->setValidationException($validation_exception)
- ->setForm($form);
+ ->addCancelButton($view_uri)
+ ->addSubmitButton($submit);
- $nav = $this->getProfileMenu();
-
- return $this->newPage()
- ->setTitle($title)
- ->setNavigation($nav)
- ->appendChild($form_box);
}
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Mar 10, 3:38 AM (1 d, 23 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7227299
Default Alt Text
D15270.id36846.diff (1 KB)
Attached To
Mode
D15270: Convert Create/Edit Column pages to dialogs
Attached
Detach File
Event Timeline
Log In to Comment