Page MenuHomePhabricator

D20547.diff
No OneTemporary

D20547.diff

diff --git a/src/applications/herald/controller/HeraldTestConsoleController.php b/src/applications/herald/controller/HeraldTestConsoleController.php
--- a/src/applications/herald/controller/HeraldTestConsoleController.php
+++ b/src/applications/herald/controller/HeraldTestConsoleController.php
@@ -271,6 +271,16 @@
$recent_id = null;
$hard_limit = 1000;
foreach ($xactions as $xaction) {
+
+ // If this transaction has Herald transcript metadata, it was applied by
+ // Herald. Exclude it from the list because the Herald rule engine always
+ // runs before Herald transactions apply, so there's no way that real
+ // rules would have seen this transaction.
+ $transcript_id = $xaction->getMetadataValue('herald:transcriptID');
+ if ($transcript_id !== null) {
+ continue;
+ }
+
$group_id = $xaction->getTransactionGroupID();
// If this is the first transaction, save the group ID: we want to

File Metadata

Mime Type
text/plain
Expires
Mar 10 2025, 3:29 AM (6 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7320129
Default Alt Text
D20547.diff (968 B)

Event Timeline