Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15336221
D16345.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D16345.diff
View Options
diff --git a/src/infrastructure/graph/ManiphestTaskGraph.php b/src/infrastructure/graph/ManiphestTaskGraph.php
--- a/src/infrastructure/graph/ManiphestTaskGraph.php
+++ b/src/infrastructure/graph/ManiphestTaskGraph.php
@@ -74,12 +74,10 @@
$link = $viewer->renderHandle($phid);
}
-
-
- if ($this->isParentTask($object)) {
+ if ($this->isParentTask($phid)) {
$marker = 'fa-chevron-circle-up bluegrey';
$marker_tip = pht('Direct Parent');
- } else if ($this->isChildTask($object)) {
+ } else if ($this->isChildTask($phid)) {
$marker = 'fa-chevron-circle-down bluegrey';
$marker_tip = pht('Direct Subtask');
} else {
@@ -128,14 +126,14 @@
));
}
- private function isParentTask(ManiphestTask $task) {
+ private function isParentTask($task_phid) {
$map = $this->getSeedMap(ManiphestTaskDependedOnByTaskEdgeType::EDGECONST);
- return isset($map[$task->getPHID()]);
+ return isset($map[$task_phid]);
}
- private function isChildTask(ManiphestTask $task) {
+ private function isChildTask($task_phid) {
$map = $this->getSeedMap(ManiphestTaskDependsOnTaskEdgeType::EDGECONST);
- return isset($map[$task->getPHID()]);
+ return isset($map[$task_phid]);
}
private function getSeedMap($type) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Mar 9, 6:31 PM (2 w, 5 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7390559
Default Alt Text
D16345.diff (1 KB)
Attached To
Mode
D16345: Fix task graph fatal for graphs containing restricted tasks
Attached
Detach File
Event Timeline
Log In to Comment