Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15335493
D11376.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
12 KB
Referenced Files
None
Subscribers
None
D11376.diff
View Options
diff --git a/webroot/rsrc/externals/javelin/core/__tests__/stratcom.js b/webroot/rsrc/externals/javelin/core/__tests__/stratcom.js
--- a/webroot/rsrc/externals/javelin/core/__tests__/stratcom.js
+++ b/webroot/rsrc/externals/javelin/core/__tests__/stratcom.js
@@ -3,10 +3,10 @@
* javelin-dom
*/
describe('Stratcom Tests', function() {
- node1 = document.createElement('div');
+ var node1 = document.createElement('div');
JX.Stratcom.addSigil(node1, 'what');
- node2 = document;
- node3 = document.createElement('div');
+ var node2 = document;
+ var node3 = document.createElement('div');
node3.className = 'what';
it('should disallow document', function() {
diff --git a/webroot/rsrc/externals/javelin/core/__tests__/util.js b/webroot/rsrc/externals/javelin/core/__tests__/util.js
--- a/webroot/rsrc/externals/javelin/core/__tests__/util.js
+++ b/webroot/rsrc/externals/javelin/core/__tests__/util.js
@@ -29,7 +29,7 @@
it('should identify an array from another context as an array', function() {
var iframe = document.createElement('iframe');
- var name = iframe.name = 'javelin-iframe-test';
+ iframe.name = 'javelin-iframe-test';
iframe.style.display = 'none';
document.body.insertBefore(iframe, document.body.firstChild);
diff --git a/webroot/rsrc/externals/javelin/core/install.js b/webroot/rsrc/externals/javelin/core/install.js
--- a/webroot/rsrc/externals/javelin/core/install.js
+++ b/webroot/rsrc/externals/javelin/core/install.js
@@ -236,7 +236,7 @@
};
};
var getter = function(prop) {
- return function(v) {
+ return function() {
return this[prop];
};
};
diff --git a/webroot/rsrc/externals/javelin/core/util.js b/webroot/rsrc/externals/javelin/core/util.js
--- a/webroot/rsrc/externals/javelin/core/util.js
+++ b/webroot/rsrc/externals/javelin/core/util.js
@@ -283,7 +283,7 @@
if (window.opera && window.opera.postError) {
window.console = {log: function(m) { window.opera.postError(m); }};
} else {
- window.console = {log: function(m) { }};
+ window.console = {log: function() {}};
}
}
diff --git a/webroot/rsrc/externals/javelin/ext/reactor/core/Reactor.js b/webroot/rsrc/externals/javelin/ext/reactor/core/Reactor.js
--- a/webroot/rsrc/externals/javelin/ext/reactor/core/Reactor.js
+++ b/webroot/rsrc/externals/javelin/ext/reactor/core/Reactor.js
@@ -38,7 +38,7 @@
* For internal use by the Reactor system.
*/
_postOrder : function(node, result, pending) {
- if (typeof result === "undefined") {
+ if (typeof result === 'undefined') {
result = [];
pending = {};
}
diff --git a/webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNode.js b/webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNode.js
--- a/webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNode.js
+++ b/webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNode.js
@@ -57,7 +57,7 @@
/**
* For internal use by the Reactor system
*/
- getNextPulse : function(pulse) {
+ getNextPulse : function() {
return this._nextPulse;
},
getTransformer : function() {
diff --git a/webroot/rsrc/externals/javelin/ext/reactor/dom/RDOM.js b/webroot/rsrc/externals/javelin/ext/reactor/dom/RDOM.js
--- a/webroot/rsrc/externals/javelin/ext/reactor/dom/RDOM.js
+++ b/webroot/rsrc/externals/javelin/ext/reactor/dom/RDOM.js
@@ -121,7 +121,7 @@
if (__DEV__) {
if (!found) {
- throw new Error("Mismatched radio button value");
+ throw new Error('Mismatched radio button value');
}
}
});
@@ -163,7 +163,7 @@
return rnode.transform(function(val) {
if (__DEV__) {
if (!(val === true || val === false)) {
- throw new Error("Send boolean values to checkboxes.");
+ throw new Error('Send boolean values to checkboxes.');
}
}
@@ -255,7 +255,7 @@
if (__DEV__) {
if (select.value !== val) {
- throw new Error("Mismatched select value");
+ throw new Error('Mismatched select value');
}
}
});
diff --git a/webroot/rsrc/externals/javelin/ext/view/HTMLView.js b/webroot/rsrc/externals/javelin/ext/view/HTMLView.js
--- a/webroot/rsrc/externals/javelin/ext/view/HTMLView.js
+++ b/webroot/rsrc/externals/javelin/ext/view/HTMLView.js
@@ -26,10 +26,10 @@
return new JX.ViewVisitor(JX.HTMLView.validate);
},
- validate: function(view, children) {
+ validate: function(view) {
var spec = this._getHTMLSpec();
if (!(view.getName() in spec)) {
- throw new Error("invalid tag");
+ throw new Error('invalid tag');
}
var tag_spec = spec[view.getName()];
@@ -37,11 +37,11 @@
var attrs = view.getAllAttributes();
for (var attr in attrs) {
if (!(attr in tag_spec)) {
- throw new Error("invalid attr");
+ throw new Error('invalid attr');
}
var validator = tag_spec[attr];
- if (typeof validator === "function") {
+ if (typeof validator === 'function') {
return validator(attrs[attr]);
}
}
@@ -51,10 +51,10 @@
_validateRel: function(target) {
return target in {
- "_blank": 1,
- "_self": 1,
- "_parent": 1,
- "_top": 1
+ '_blank': 1,
+ '_self': 1,
+ '_parent': 1,
+ '_top': 1
};
},
_getHTMLSpec: function() {
diff --git a/webroot/rsrc/externals/javelin/ext/view/ViewInterpreter.js b/webroot/rsrc/externals/javelin/ext/view/ViewInterpreter.js
--- a/webroot/rsrc/externals/javelin/ext/view/ViewInterpreter.js
+++ b/webroot/rsrc/externals/javelin/ext/view/ViewInterpreter.js
@@ -56,7 +56,7 @@
if (properties instanceof JX.View ||
properties instanceof JX.HTML ||
properties.nodeType ||
- typeof properties === "string") {
+ typeof properties === 'string') {
children.unshift(properties);
properties = {};
}
diff --git a/webroot/rsrc/externals/javelin/ext/view/ViewPlaceholder.js b/webroot/rsrc/externals/javelin/ext/view/ViewPlaceholder.js
--- a/webroot/rsrc/externals/javelin/ext/view/ViewPlaceholder.js
+++ b/webroot/rsrc/externals/javelin/ext/view/ViewPlaceholder.js
@@ -53,12 +53,12 @@
-JX.behavior('view-placeholder', function(config, statics) {
+JX.behavior('view-placeholder', function(config) {
JX.ViewPlaceholder.register(config.trigger_id, config.id, function() {
var replace = JX.$(config.id);
var children = config.children;
- if (typeof children === "string") {
+ if (typeof children === 'string') {
children = JX.$H(children);
}
diff --git a/webroot/rsrc/externals/javelin/ext/view/__tests__/ViewRenderer.js b/webroot/rsrc/externals/javelin/ext/view/__tests__/ViewRenderer.js
--- a/webroot/rsrc/externals/javelin/ext/view/__tests__/ViewRenderer.js
+++ b/webroot/rsrc/externals/javelin/ext/view/__tests__/ViewRenderer.js
@@ -11,11 +11,11 @@
var child = new JX.View({});
var parent = new JX.View({});
parent.addChild(child);
- child.render = function(_) {
+ child.render = function() {
child_rendered = true;
};
- parent.render = function(rendered_children) {
+ parent.render = function() {
child_rendered_first = child_rendered;
};
diff --git a/webroot/rsrc/externals/javelin/lib/Leader.js b/webroot/rsrc/externals/javelin/lib/Leader.js
--- a/webroot/rsrc/externals/javelin/lib/Leader.js
+++ b/webroot/rsrc/externals/javelin/lib/Leader.js
@@ -219,7 +219,7 @@
_read: function() {
var self = JX.Leader;
- leader = window.localStorage.getItem(self._leaderKey) || '0:0';
+ var leader = window.localStorage.getItem(self._leaderKey) || '0:0';
leader = leader.split(':');
return {
@@ -305,4 +305,3 @@
}
});
-
diff --git a/webroot/rsrc/externals/javelin/lib/Request.js b/webroot/rsrc/externals/javelin/lib/Request.js
--- a/webroot/rsrc/externals/javelin/lib/Request.js
+++ b/webroot/rsrc/externals/javelin/lib/Request.js
@@ -39,10 +39,10 @@
try {
return new XMLHttpRequest();
} catch (x) {
- return new ActiveXObject("Msxml2.XMLHTTP");
+ return new ActiveXObject('Msxml2.XMLHTTP');
}
} catch (x) {
- return new ActiveXObject("Microsoft.XMLHTTP");
+ return new ActiveXObject('Microsoft.XMLHTTP');
}
},
@@ -269,10 +269,10 @@
try {
if (typeof DOMParser != 'undefined') {
var parser = new DOMParser();
- doc = parser.parseFromString(text, "text/xml");
+ doc = parser.parseFromString(text, 'text/xml');
} else { // IE
// an XDomainRequest
- doc = new ActiveXObject("Microsoft.XMLDOM");
+ doc = new ActiveXObject('Microsoft.XMLDOM');
doc.async = false;
doc.loadXML(xport.responseText);
}
diff --git a/webroot/rsrc/externals/javelin/lib/Resource.js b/webroot/rsrc/externals/javelin/lib/Resource.js
--- a/webroot/rsrc/externals/javelin/lib/Resource.js
+++ b/webroot/rsrc/externals/javelin/lib/Resource.js
@@ -25,7 +25,7 @@
*/
load: function(list, callback) {
var resources = {},
- uri, resource, path, type;
+ uri, resource, path;
list = JX.$AX(list);
diff --git a/webroot/rsrc/externals/javelin/lib/WebSocket.js b/webroot/rsrc/externals/javelin/lib/WebSocket.js
--- a/webroot/rsrc/externals/javelin/lib/WebSocket.js
+++ b/webroot/rsrc/externals/javelin/lib/WebSocket.js
@@ -107,7 +107,7 @@
/**
* Callback for connection open.
*/
- _onopen: function(e) {
+ _onopen: function() {
this._isOpen = true;
// Reset the reconnect delay, since we connected successfully.
@@ -144,7 +144,7 @@
/**
* Callback for connection close.
*/
- _onclose: function(e) {
+ _onclose: function() {
this._isOpen = false;
var done = false;
diff --git a/webroot/rsrc/externals/javelin/lib/__tests__/JSON.js b/webroot/rsrc/externals/javelin/lib/__tests__/JSON.js
--- a/webroot/rsrc/externals/javelin/lib/__tests__/JSON.js
+++ b/webroot/rsrc/externals/javelin/lib/__tests__/JSON.js
@@ -7,7 +7,7 @@
it('should encode and decode an object', function() {
var object = {
a: [0, 1, 2],
- s: "Javelin Stuffs",
+ s: 'Javelin Stuffs',
u: '\x01',
n: 1,
f: 3.14,
diff --git a/webroot/rsrc/externals/javelin/lib/__tests__/URI.js b/webroot/rsrc/externals/javelin/lib/__tests__/URI.js
--- a/webroot/rsrc/externals/javelin/lib/__tests__/URI.js
+++ b/webroot/rsrc/externals/javelin/lib/__tests__/URI.js
@@ -43,7 +43,7 @@
});
function charRange(from, to) {
- res = '';
+ var res = '';
for (var i = from.charCodeAt(0); i <= to.charCodeAt(0); i++) {
res += String.fromCharCode(i);
}
diff --git a/webroot/rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js b/webroot/rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js
--- a/webroot/rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js
+++ b/webroot/rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js
@@ -250,7 +250,6 @@
}
this._lastvalue = focus.value;
- var root = this._root;
var metrics = JX.DOM.textMetrics(
this._focus,
'jx-tokenizer-metrics');
@@ -353,9 +352,6 @@
},
_onkeydown : function(e) {
- var focus = this._focus;
- var root = this._root;
-
var raw = e.getRawEvent();
if (raw.ctrlKey || raw.metaKey || raw.altKey) {
return;
diff --git a/webroot/rsrc/externals/javelin/lib/control/typeahead/Typeahead.js b/webroot/rsrc/externals/javelin/lib/control/typeahead/Typeahead.js
--- a/webroot/rsrc/externals/javelin/lib/control/typeahead/Typeahead.js
+++ b/webroot/rsrc/externals/javelin/lib/control/typeahead/Typeahead.js
@@ -137,9 +137,9 @@
if (__DEV__) {
if (!this._datasource) {
throw new Error(
- "JX.Typeahead.start(): " +
- "No datasource configured. Create a datasource and call " +
- "setDatasource().");
+ 'JX.Typeahead.start(): ' +
+ 'No datasource configured. Create a datasource and call ' +
+ 'setDatasource().');
}
}
this.updatePlaceholder();
@@ -402,7 +402,7 @@
this._choose(this._display[this._focus]);
return true;
} else {
- result = this.invoke('query', this._control.value);
+ var result = this.invoke('query', this._control.value);
if (result.getPrevented()) {
return true;
}
diff --git a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js
--- a/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js
+++ b/webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js
@@ -147,7 +147,7 @@
this._startListener.remove();
},
- didChange : function(value) {
+ didChange : function() {
return;
},
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Mar 9, 3:55 PM (2 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7389613
Default Alt Text
D11376.diff (12 KB)
Attached To
Mode
D11376: Fix various lint issues in rJX
Attached
Detach File
Event Timeline
Log In to Comment