Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15334555
D17386.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D17386.diff
View Options
diff --git a/src/phage/action/PhageAgentAction.php b/src/phage/action/PhageAgentAction.php
--- a/src/phage/action/PhageAgentAction.php
+++ b/src/phage/action/PhageAgentAction.php
@@ -99,13 +99,15 @@
$exit_code = $message['err'];
+ $command->setExitCode($exit_code);
+
if ($exit_code != 0) {
$exit_code = $this->formatOutput(
pht(
'Command ("%s") exited nonzero ("%s")!',
$command->getCommand(),
$exit_code),
- $key.'/exit');
+ $command->getLabel());
fprintf(STDOUT, '%s', $exit_code);
}
diff --git a/src/phage/action/PhageExecuteAction.php b/src/phage/action/PhageExecuteAction.php
--- a/src/phage/action/PhageExecuteAction.php
+++ b/src/phage/action/PhageExecuteAction.php
@@ -5,6 +5,7 @@
private $command;
private $label;
+ private $exitCode;
public function isContainerAction() {
return false;
@@ -28,4 +29,13 @@
return $this->label;
}
+ public function setExitCode($exit_code) {
+ $this->exitCode = $exit_code;
+ return $this;
+ }
+
+ public function getExitCode() {
+ return $this->exitCode;
+ }
+
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Mar 9, 10:19 AM (2 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7388232
Default Alt Text
D17386.diff (1 KB)
Attached To
Mode
D17386: Record command exit status on Execute objects in Phage
Attached
Detach File
Event Timeline
Log In to Comment