Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15333676
D14365.id34685.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
856 B
Referenced Files
None
Subscribers
None
D14365.id34685.diff
View Options
diff --git a/src/land/ArcanistGitLandEngine.php b/src/land/ArcanistGitLandEngine.php
--- a/src/land/ArcanistGitLandEngine.php
+++ b/src/land/ArcanistGitLandEngine.php
@@ -148,8 +148,11 @@
try {
if ($this->getShouldSquash()) {
+ // NOTE: We're explicitly specifying "--ff" to override the presence
+ // of "merge.ff" options in user configuration.
+
$api->execxLocal(
- 'merge --no-stat --no-commit --squash -- %s',
+ 'merge --no-stat --no-commit --ff --squash -- %s',
$source);
} else {
$api->execxLocal(
@@ -200,7 +203,7 @@
pht('PUSHING'),
pht('Pushing changes to "%s".', $this->getTargetFullRef()));
- list($err) = $api->execPassthru(
+ $err = $api->execPassthru(
'push -- %s %s:%s',
$this->getTargetRemote(),
$this->mergedRef,
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Mar 9, 3:59 AM (1 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7223733
Default Alt Text
D14365.id34685.diff (856 B)
Attached To
Mode
D14365: Explicitly provide "--ff" when performing squash merges in "arc land" under Git
Attached
Detach File
Event Timeline
Log In to Comment