D11342.id27264.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D11342.id27264.diff
View Options

	diff --git a/src/lint/linter/ArcanistChmodLinter.php b/src/lint/linter/ArcanistChmodLinter.php
	--- a/src/lint/linter/ArcanistChmodLinter.php
	+++ b/src/lint/linter/ArcanistChmodLinter.php
	@@ -27,20 +27,18 @@
	return 'chmod';
	}

	- protected function shouldLintBinaryFiles() {
	- return true;
	- }
	-
	public function getLintNameMap() {
	return array(
	self::LINT_INVALID_EXECUTABLE => pht('Invalid Executable'),
	);
	}

	- public function getLintSeverityMap() {
	- return array(
	- self::LINT_INVALID_EXECUTABLE => ArcanistLintSeverity::SEVERITY_WARNING,
	- );
	+ protected function getDefaultMessageSeverity($code) {
	+ return ArcanistLintSeverity::SEVERITY_WARNING;
	+ }
	+
	+ protected function shouldLintBinaryFiles() {
	+ return true;
	}

	public function lintPath($path) {
	@@ -97,10 +95,11 @@
	self::LINT_INVALID_EXECUTABLE,
	pht("'%s' files should not be executable.", $mime));
	return;
	- }

	- // Path is a binary file, which makes it a valid executable.
	- return;
	+ default:
	+ // Path is a binary file, which makes it a valid executable.
	+ return;
	+ }
	} else if ($this->getShebang($path)) {
	// Path contains a shebang, which makes it a valid executable.
	return;