Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15331320
D13368.id32365.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D13368.id32365.diff
View Options
diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
*/
return array(
'names' => array(
- 'core.pkg.css' => '173fc33c',
+ 'core.pkg.css' => '604293a7',
'core.pkg.js' => 'f1e8abd7',
'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => 'fe951924',
@@ -150,7 +150,7 @@
'rsrc/css/phui/phui-status.css' => '888cedb8',
'rsrc/css/phui/phui-tag-view.css' => '402691cc',
'rsrc/css/phui/phui-text.css' => 'cf019f54',
- 'rsrc/css/phui/phui-timeline-view.css' => '2d181f3f',
+ 'rsrc/css/phui/phui-timeline-view.css' => '47b18876',
'rsrc/css/phui/phui-workboard-view.css' => '0cac51a4',
'rsrc/css/phui/phui-workpanel-view.css' => '4bdc2562',
'rsrc/css/sprite-login.css' => 'a3526809',
@@ -793,7 +793,7 @@
'phui-tag-view-css' => '402691cc',
'phui-text-css' => 'cf019f54',
'phui-theme-css' => 'd4a49411',
- 'phui-timeline-view-css' => '2d181f3f',
+ 'phui-timeline-view-css' => '47b18876',
'phui-workboard-view-css' => '0cac51a4',
'phui-workpanel-view-css' => '4bdc2562',
'phuix-action-list-view' => 'b5c256b8',
diff --git a/src/view/phui/PHUITimelineEventView.php b/src/view/phui/PHUITimelineEventView.php
--- a/src/view/phui/PHUITimelineEventView.php
+++ b/src/view/phui/PHUITimelineEventView.php
@@ -354,13 +354,16 @@
),
'');
- $image = phutil_tag(
- 'div',
- array(
- 'style' => 'background-image: url('.$image_uri.')',
- 'class' => 'phui-timeline-image',
- ),
- '');
+ $image = null;
+ if ($image_uri) {
+ $image = phutil_tag(
+ 'div',
+ array(
+ 'style' => 'background-image: url('.$image_uri.')',
+ 'class' => 'phui-timeline-image',
+ ),
+ '');
+ }
$content_classes = array();
$content_classes[] = 'phui-timeline-content';
diff --git a/webroot/rsrc/css/phui/phui-timeline-view.css b/webroot/rsrc/css/phui/phui-timeline-view.css
--- a/webroot/rsrc/css/phui/phui-timeline-view.css
+++ b/webroot/rsrc/css/phui/phui-timeline-view.css
@@ -105,16 +105,16 @@
}
.device-desktop .phui-timeline-major-event .phui-timeline-image {
- width: 48px;
- height: 48px;
+ width: 50px;
+ height: 50px;
top: 0px;
left: -62px;
}
.device-desktop .phui-timeline-minor-event .phui-timeline-image {
- width: 26px;
- height: 26px;
- background-size: 26px auto;
+ width: 28px;
+ height: 28px;
+ background-size: 28px auto;
left: -41px;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Mar 8, 8:55 AM (2 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7225508
Default Alt Text
D13368.id32365.diff (2 KB)
Attached To
Mode
D13368: [Redesign] Clean up timeline images
Attached
Detach File
Event Timeline
Log In to Comment