Page MenuHomePhabricator

D18208.id43789.diff
No OneTemporary

D18208.id43789.diff

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -75,7 +75,7 @@
'rsrc/css/application/diffusion/diffusion-readme.css' => '419dd5b6',
'rsrc/css/application/diffusion/diffusion-repository.css' => 'ee6f20ec',
'rsrc/css/application/diffusion/diffusion-source.css' => '750add59',
- 'rsrc/css/application/diffusion/diffusion.css' => '08991f7e',
+ 'rsrc/css/application/diffusion/diffusion.css' => '8d01932f',
'rsrc/css/application/feed/feed.css' => 'ecd4ec57',
'rsrc/css/application/files/global-drag-and-drop.css' => '5c1b47c2',
'rsrc/css/application/flag/flag.css' => 'bba8f811',
@@ -571,7 +571,7 @@
'differential-revision-history-css' => '0e8eb855',
'differential-revision-list-css' => 'f3c47d33',
'differential-table-of-contents-css' => 'ae4b7a55',
- 'diffusion-css' => '08991f7e',
+ 'diffusion-css' => '8d01932f',
'diffusion-icons-css' => '0c15255e',
'diffusion-readme-css' => '419dd5b6',
'diffusion-repository-css' => 'ee6f20ec',
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryController.php b/src/applications/diffusion/controller/DiffusionRepositoryController.php
--- a/src/applications/diffusion/controller/DiffusionRepositoryController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryController.php
@@ -94,9 +94,15 @@
'action' => 'clone',
));
+ if ($repository->isSVN()) {
+ $clone_text = pht('Checkout');
+ } else {
+ $clone_text = pht('Clone');
+ }
+
$clone_button = id(new PHUIButtonView())
->setTag('a')
- ->setText('Clone')
+ ->setText($clone_text)
->setColor(PHUIButtonView::GREEN)
->setIcon('fa-download')
->setWorkflow(true)
@@ -104,17 +110,21 @@
$bar = id(new PHUILeftRightView())
->setLeft($locate_file)
- ->setRight($clone_button);
+ ->setRight($clone_button)
+ ->addClass('diffusion-action-bar');
$view = id(new PHUITwoColumnView())
->setHeader($header)
- ->setTabs($tabs)
->setFooter(array(
$bar,
$description,
$content,
));
+ if ($page_has_content) {
+ $view->setTabs($tabs);
+ }
+
return $this->newPage()
->setTitle(
array(
diff --git a/webroot/rsrc/css/application/diffusion/diffusion.css b/webroot/rsrc/css/application/diffusion/diffusion.css
--- a/webroot/rsrc/css/application/diffusion/diffusion.css
+++ b/webroot/rsrc/css/application/diffusion/diffusion.css
@@ -12,8 +12,12 @@
display: block;
}
+.diffusion-action-bar {
+ margin-bottom: 16px;
+}
+
.diffusion-profile-locate .phui-form-view {
- margin: 0 0 16px 0;
+ margin: 0;
padding: 0;
}

File Metadata

Mime Type
text/plain
Expires
Sat, Mar 8, 2:30 AM (3 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7365472
Default Alt Text
D18208.id43789.diff (2 KB)

Event Timeline