Page MenuHomePhabricator
Files F15314765

D20172.diff
No OneTemporary
Actions

D20172.diff
View Options

diff --git a/src/workflow/ArcanistDiffWorkflow.php b/src/workflow/ArcanistDiffWorkflow.php
--- a/src/workflow/ArcanistDiffWorkflow.php
+++ b/src/workflow/ArcanistDiffWorkflow.php
@@ -1820,17 +1820,56 @@
$this->checkRevisionOwnership(head($result));
break;
case 'reviewers':
- $untils = array();
+ $away = array();
foreach ($result as $user) {
- if (idx($user, 'currentStatus') == 'away') {
- $untils[] = $user['currentStatusUntil'];
+ if (idx($user, 'currentStatus') != 'away') {
+ continue;
}
+
+ $username = $user['userName'];
+ $real_name = $user['realName'];
+
+ if (strlen($real_name)) {
+ $name = pht('%s (%s)', $username, $real_name);
+ } else {
+ $name = pht('%s', $username);
+ }
+
+ $away[] = array(
+ 'name' => $name,
+ 'until' => $user['currentStatusUntil'],
+ );
}
- if (count($untils) == count($reviewers)) {
- $until = date('l, M j Y', min($untils));
- $confirm = pht(
- 'All reviewers are away until %s. Continue anyway?',
- $until);
+
+ if ($away) {
+ if (count($away) == count($reviewers)) {
+ $earliest_return = min(ipull($away, 'until'));
+
+ $message = pht(
+ 'All reviewers are away until %s:',
+ date('l, M j Y', $earliest_return));
+ } else {
+ $message = pht('Some reviewers are currently away:');
+ }
+
+ echo tsprintf(
+ "%s\n\n",
+ $message);
+
+ $list = id(new PhutilConsoleList());
+ foreach ($away as $spec) {
+ $list->addItem(
+ pht(
+ '%s (until %s)',
+ $spec['name'],
+ date('l, M j Y', $spec['until'])));
+ }
+
+ echo tsprintf(
+ '%B',
+ $list->drawConsoleString());
+
+ $confirm = pht('Continue even though reviewers are unavailable?');
if (!phutil_console_confirm($confirm)) {
throw new ArcanistUsageException(
pht('Specify available reviewers and retry.'));

File Metadata

Mime Type
text/plain
Expires
Fri, Mar 7, 5:10 PM (2 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7339028
Default Alt Text
D20172.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility