Page MenuHomePhabricator
Files F15310315

D11651.id28045.diff
No OneTemporary
Actions

D11651.id28045.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
*/
return array(
'names' => array(
- 'core.pkg.css' => '8be366b7',
+ 'core.pkg.css' => 'adb53fe7',
'core.pkg.js' => '65e04767',
'darkconsole.pkg.js' => '8ab24e01',
'differential.pkg.css' => '8af45893',
@@ -137,7 +137,7 @@
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
'rsrc/css/phui/phui-list.css' => '53deb25c',
'rsrc/css/phui/phui-object-box.css' => 'b8b7fd78',
- 'rsrc/css/phui/phui-object-item-list-view.css' => '2670a4a9',
+ 'rsrc/css/phui/phui-object-item-list-view.css' => 'ace03f3e',
'rsrc/css/phui/phui-pinboard-view.css' => '3dd4a269',
'rsrc/css/phui/phui-property-list-view.css' => '51480060',
'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b',
@@ -785,7 +785,7 @@
'phui-info-panel-css' => '27ea50a1',
'phui-list-view-css' => '53deb25c',
'phui-object-box-css' => 'b8b7fd78',
- 'phui-object-item-list-view-css' => '2670a4a9',
+ 'phui-object-item-list-view-css' => 'ace03f3e',
'phui-pinboard-view-css' => '3dd4a269',
'phui-property-list-view-css' => '51480060',
'phui-remarkup-preview-css' => '19ad512b',
diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php
--- a/src/applications/differential/controller/DifferentialRevisionViewController.php
+++ b/src/applications/differential/controller/DifferentialRevisionViewController.php
@@ -778,6 +778,7 @@
$user = $this->getRequest()->getUser();
$view = id(new DifferentialRevisionListView())
+ ->setHeader(pht('Open Revisions Affecting These Files'))
->setRevisions($revisions)
->setUser($user);
@@ -785,9 +786,7 @@
$handles = $this->loadViewerHandles($phids);
$view->setHandles($handles);
- return id(new PHUIObjectBoxView())
- ->setHeaderText(pht('Open Revisions Affecting These Files'))
- ->appendChild($view);
+ return $view;
}
diff --git a/src/applications/differential/view/DifferentialRevisionListView.php b/src/applications/differential/view/DifferentialRevisionListView.php
--- a/src/applications/differential/view/DifferentialRevisionListView.php
+++ b/src/applications/differential/view/DifferentialRevisionListView.php
@@ -179,9 +179,16 @@
$list->addItem($item);
}
- $list->setHeader($this->header);
$list->setNoDataString($this->noDataString);
+
+ if ($this->header) {
+ $list->setFlush(true);
+ $list = id(new PHUIObjectBoxView())
+ ->setHeaderText($this->header)
+ ->appendChild($list);
+ }
+
return $list;
}
diff --git a/src/applications/diffusion/controller/DiffusionBrowseController.php b/src/applications/diffusion/controller/DiffusionBrowseController.php
--- a/src/applications/diffusion/controller/DiffusionBrowseController.php
+++ b/src/applications/diffusion/controller/DiffusionBrowseController.php
@@ -208,6 +208,7 @@
}
$view = id(new DifferentialRevisionListView())
+ ->setHeader(pht('Pending Differential Revisions'))
->setRevisions($revisions)
->setUser($user);
@@ -215,9 +216,7 @@
$handles = $this->loadViewerHandles($phids);
$view->setHandles($handles);
- return id(new PHUIObjectBoxView())
- ->setHeaderText(pht('Pending Differential Revisions'))
- ->appendChild($view);
+ return $view;
}
}
diff --git a/webroot/rsrc/css/phui/phui-object-item-list-view.css b/webroot/rsrc/css/phui/phui-object-item-list-view.css
--- a/webroot/rsrc/css/phui/phui-object-item-list-view.css
+++ b/webroot/rsrc/css/phui/phui-object-item-list-view.css
@@ -61,6 +61,10 @@
margin: 0 0 4px 0;
}
+.phui-object-box .phui-object-list-flush .phui-object-item {
+ margin: 0;
+}
+
.phui-object-item-name {
font-weight: bold;
padding: 8px 8px 0;

File Metadata

Mime Type
text/plain
Expires
Fri, Mar 7, 8:55 AM (2 d, 6 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7328599
Default Alt Text
D11651.id28045.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility