Page MenuHomePhabricator

D13085.diff
No OneTemporary

D13085.diff

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -142,7 +142,7 @@
'rsrc/css/phui/phui-list.css' => 'e448b6ba',
'rsrc/css/phui/phui-object-box.css' => 'c57e6647',
'rsrc/css/phui/phui-object-item-list-view.css' => '29ded459',
- 'rsrc/css/phui/phui-pinboard-view.css' => '55b27bc3',
+ 'rsrc/css/phui/phui-pinboard-view.css' => '2495140e',
'rsrc/css/phui/phui-property-list-view.css' => '1baf23eb',
'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b',
'rsrc/css/phui/phui-spacing.css' => '042804d6',
@@ -778,7 +778,7 @@
'phui-list-view-css' => 'e448b6ba',
'phui-object-box-css' => 'c57e6647',
'phui-object-item-list-view-css' => '29ded459',
- 'phui-pinboard-view-css' => '55b27bc3',
+ 'phui-pinboard-view-css' => '2495140e',
'phui-property-list-view-css' => '1baf23eb',
'phui-remarkup-preview-css' => '19ad512b',
'phui-spacing-css' => '042804d6',
diff --git a/src/view/phui/PHUIPinboardItemView.php b/src/view/phui/PHUIPinboardItemView.php
--- a/src/view/phui/PHUIPinboardItemView.php
+++ b/src/view/phui/PHUIPinboardItemView.php
@@ -115,7 +115,7 @@
$classes[] = 'phui-pinboard-item-disabled';
}
- return phutil_tag(
+ $item = phutil_tag(
'div',
array(
'class' => implode(' ', $classes),
@@ -126,6 +126,13 @@
$content,
$icons,
));
+
+ return phutil_tag(
+ 'li',
+ array(
+ 'class' => 'phui-pinboard-list-item',
+ ),
+ $item);
}
}
diff --git a/src/view/phui/PHUIPinboardView.php b/src/view/phui/PHUIPinboardView.php
--- a/src/view/phui/PHUIPinboardView.php
+++ b/src/view/phui/PHUIPinboardView.php
@@ -27,7 +27,7 @@
}
return phutil_tag(
- 'div',
+ 'ul',
array(
'class' => 'phui-pinboard-view',
),
diff --git a/webroot/rsrc/css/phui/phui-pinboard-view.css b/webroot/rsrc/css/phui/phui-pinboard-view.css
--- a/webroot/rsrc/css/phui/phui-pinboard-view.css
+++ b/webroot/rsrc/css/phui/phui-pinboard-view.css
@@ -3,16 +3,13 @@
*/
.phui-pinboard-view {
- padding: 8px 0 16px 16px;
- overflow: hidden;
-}
-
-.dashboard-pane .phui-pinboard-view {
padding: 16px 8px;
+ overflow: hidden;
+ text-align: center;
}
-.device-phone .phui-pinboard-view {
- padding: 0;
+.phui-pinboard-list-item {
+ display: inline;
}
.phui-pinboard-item-view {
@@ -25,7 +22,7 @@
}
.phui-pinboard-view .phui-pinboard-item-view {
- float: left;
+ display: inline-block;
}
.device-desktop .phui-pinboard-item-view:hover {

File Metadata

Mime Type
text/plain
Expires
Fri, Mar 7, 7:27 AM (18 h, 34 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7326605
Default Alt Text
D13085.diff (2 KB)

Event Timeline