Page MenuHomePhabricator
Files F15309224

D19654.id.diff
No OneTemporary
Actions

D19654.id.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -423,7 +423,7 @@
'rsrc/js/application/search/behavior-reorder-profile-menu-items.js' => 'e2e0a072',
'rsrc/js/application/search/behavior-reorder-queries.js' => 'e9581f08',
'rsrc/js/application/slowvote/behavior-slowvote-embed.js' => '887ad43f',
- 'rsrc/js/application/transactions/behavior-comment-actions.js' => '54110499',
+ 'rsrc/js/application/transactions/behavior-comment-actions.js' => '038bf27f',
'rsrc/js/application/transactions/behavior-reorder-configs.js' => 'd7a74243',
'rsrc/js/application/transactions/behavior-reorder-fields.js' => 'b59e1e96',
'rsrc/js/application/transactions/behavior-show-older-transactions.js' => '8f29b364',
@@ -575,7 +575,7 @@
'javelin-behavior-bulk-job-reload' => 'edf8a145',
'javelin-behavior-calendar-month-view' => 'fe33e256',
'javelin-behavior-choose-control' => '327a00d1',
- 'javelin-behavior-comment-actions' => '54110499',
+ 'javelin-behavior-comment-actions' => '038bf27f',
'javelin-behavior-config-reorder-fields' => 'b6993408',
'javelin-behavior-conpherence-menu' => '4047cd35',
'javelin-behavior-conpherence-participant-pane' => 'd057e45a',
@@ -905,6 +905,15 @@
'javelin-behavior',
'javelin-uri',
),
+ '038bf27f' => array(
+ 'javelin-behavior',
+ 'javelin-stratcom',
+ 'javelin-workflow',
+ 'javelin-dom',
+ 'phuix-form-control-view',
+ 'phuix-icon-view',
+ 'javelin-behavior-phabricator-gesture',
+ ),
'040fce04' => array(
'javelin-behavior',
'javelin-request',
@@ -1251,15 +1260,6 @@
'javelin-vector',
'javelin-typeahead-static-source',
),
- 54110499 => array(
- 'javelin-behavior',
- 'javelin-stratcom',
- 'javelin-workflow',
- 'javelin-dom',
- 'phuix-form-control-view',
- 'phuix-icon-view',
- 'javelin-behavior-phabricator-gesture',
- ),
'549459b8' => array(
'javelin-behavior',
),
diff --git a/src/applications/transactions/response/PhabricatorApplicationTransactionResponse.php b/src/applications/transactions/response/PhabricatorApplicationTransactionResponse.php
--- a/src/applications/transactions/response/PhabricatorApplicationTransactionResponse.php
+++ b/src/applications/transactions/response/PhabricatorApplicationTransactionResponse.php
@@ -83,7 +83,15 @@
$xactions[$key] = hsprintf('%s', $xaction);
}
+ $aural = phutil_tag(
+ 'h3',
+ array(
+ 'class' => 'aural-only',
+ ),
+ pht('Comment Preview'));
+
$content = array(
+ 'header' => hsprintf('%s', $aural),
'xactions' => $xactions,
'spacer' => PHUITimelineView::renderSpacer(),
'previewContent' => hsprintf('%s', $this->getPreviewContent()),
diff --git a/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php b/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
--- a/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
+++ b/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
@@ -245,6 +245,13 @@
->setFlush(true)
->addClass('phui-comment-form-view')
->addSigil('phui-comment-form')
+ ->appendChild(
+ phutil_tag(
+ 'h3',
+ array(
+ 'class' => 'aural-only',
+ ),
+ pht('Add Comment')))
->appendChild($image)
->appendChild($badge_view)
->appendChild($wedge)
diff --git a/src/view/phui/PHUITimelineView.php b/src/view/phui/PHUITimelineView.php
--- a/src/view/phui/PHUITimelineView.php
+++ b/src/view/phui/PHUITimelineView.php
@@ -83,7 +83,15 @@
'class' => 'phui-timeline-view',
'id' => $this->id,
),
- $events);
+ array(
+ phutil_tag(
+ 'h3',
+ array(
+ 'class' => 'aural-only',
+ ),
+ pht('Event Timeline')),
+ $events,
+ ));
}
public function buildEvents() {
diff --git a/webroot/rsrc/js/application/transactions/behavior-comment-actions.js b/webroot/rsrc/js/application/transactions/behavior-comment-actions.js
--- a/webroot/rsrc/js/application/transactions/behavior-comment-actions.js
+++ b/webroot/rsrc/js/application/transactions/behavior-comment-actions.js
@@ -105,6 +105,7 @@
JX.DOM.setContent(
preview_root,
[
+ JX.$H(response.header),
JX.$H(response.xactions.join('')),
JX.$H(response.previewContent)
]);

File Metadata

Mime Type
text/plain
Expires
Fri, Mar 7, 7:03 AM (2 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7225501
Default Alt Text
D19654.id.diff (4 KB)

Event Timeline

Phabricator · Built by Phacility