Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15302087
D12836.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D12836.diff
View Options
diff --git a/src/workflow/ArcanistBackoutWorkflow.php b/src/workflow/ArcanistBackoutWorkflow.php
--- a/src/workflow/ArcanistBackoutWorkflow.php
+++ b/src/workflow/ArcanistBackoutWorkflow.php
@@ -183,7 +183,8 @@
// Create commit message and execute the commit
$message = $this->buildCommitMessage($commit_hash);
$repository_api->doCommit($message);
- $console->writeOut(pht('Double-check the commit and push when ready.')."\n");
+ $console->writeOut("%s\n",
+ pht('Double-check the commit and push when ready.'));
}
}
diff --git a/src/workflow/ArcanistBookmarkWorkflow.php b/src/workflow/ArcanistBookmarkWorkflow.php
--- a/src/workflow/ArcanistBookmarkWorkflow.php
+++ b/src/workflow/ArcanistBookmarkWorkflow.php
@@ -29,8 +29,4 @@
return array('hg');
}
- public function run() {
- return parent::run();
- }
-
}
diff --git a/src/workflow/ArcanistBranchWorkflow.php b/src/workflow/ArcanistBranchWorkflow.php
--- a/src/workflow/ArcanistBranchWorkflow.php
+++ b/src/workflow/ArcanistBranchWorkflow.php
@@ -29,8 +29,4 @@
return array('git');
}
- public function run() {
- return parent::run();
- }
-
}
diff --git a/src/workflow/ArcanistLiberateWorkflow.php b/src/workflow/ArcanistLiberateWorkflow.php
--- a/src/workflow/ArcanistLiberateWorkflow.php
+++ b/src/workflow/ArcanistLiberateWorkflow.php
@@ -223,8 +223,10 @@
if (preg_match('/^[a-z-]+$/', $name)) {
break;
} else {
- echo pht(
- 'Library name should contain only lowercase letters and hyphens.')."\n";
+ echo phutil_console_format(
+ "%s\n",
+ pht(
+ 'Library name should contain only lowercase letters and hyphens.'));
}
} while (true);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Mar 6, 6:35 PM (2 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7304400
Default Alt Text
D12836.diff (1 KB)
Attached To
Mode
D12836: Minor linter fixes
Attached
Detach File
Event Timeline
Log In to Comment