Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15301670
D7492.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
8 KB
Referenced Files
None
Subscribers
None
D7492.diff
View Options
Index: src/__celerity_resource_map__.php
===================================================================
--- src/__celerity_resource_map__.php
+++ src/__celerity_resource_map__.php
@@ -3933,7 +3933,7 @@
),
'phui-property-list-view-css' =>
array(
- 'uri' => '/res/b307acfe/rsrc/css/phui/phui-property-list-view.css',
+ 'uri' => '/res/68275e2c/rsrc/css/phui/phui-property-list-view.css',
'type' => 'css',
'requires' =>
array(
@@ -4321,7 +4321,7 @@
), array(
'packages' =>
array(
- 'b05e33c6' =>
+ 'ef078368' =>
array(
'name' => 'core.pkg.css',
'symbols' =>
@@ -4370,7 +4370,7 @@
41 => 'phabricator-tag-view-css',
42 => 'phui-list-view-css',
),
- 'uri' => '/res/pkg/b05e33c6/core.pkg.css',
+ 'uri' => '/res/pkg/ef078368/core.pkg.css',
'type' => 'css',
),
'2c1dba03' =>
@@ -4562,15 +4562,15 @@
),
'reverse' =>
array(
- 'aphront-dialog-view-css' => 'b05e33c6',
- 'aphront-error-view-css' => 'b05e33c6',
- 'aphront-list-filter-view-css' => 'b05e33c6',
- 'aphront-pager-view-css' => 'b05e33c6',
- 'aphront-panel-view-css' => 'b05e33c6',
- 'aphront-table-view-css' => 'b05e33c6',
- 'aphront-tokenizer-control-css' => 'b05e33c6',
- 'aphront-tooltip-css' => 'b05e33c6',
- 'aphront-typeahead-control-css' => 'b05e33c6',
+ 'aphront-dialog-view-css' => 'ef078368',
+ 'aphront-error-view-css' => 'ef078368',
+ 'aphront-list-filter-view-css' => 'ef078368',
+ 'aphront-pager-view-css' => 'ef078368',
+ 'aphront-panel-view-css' => 'ef078368',
+ 'aphront-table-view-css' => 'ef078368',
+ 'aphront-tokenizer-control-css' => 'ef078368',
+ 'aphront-tooltip-css' => 'ef078368',
+ 'aphront-typeahead-control-css' => 'ef078368',
'differential-changeset-view-css' => '1084b12b',
'differential-core-view-css' => '1084b12b',
'differential-inline-comment-editor' => '5e9e5c4e',
@@ -4584,7 +4584,7 @@
'differential-table-of-contents-css' => '1084b12b',
'diffusion-commit-view-css' => '7aa115b4',
'diffusion-icons-css' => '7aa115b4',
- 'global-drag-and-drop-css' => 'b05e33c6',
+ 'global-drag-and-drop-css' => 'ef078368',
'inline-comment-summary-css' => '1084b12b',
'javelin-aphlict' => '2c1dba03',
'javelin-behavior' => '3e3be199',
@@ -4659,56 +4659,56 @@
'javelin-util' => '3e3be199',
'javelin-vector' => '3e3be199',
'javelin-workflow' => '3e3be199',
- 'lightbox-attachment-css' => 'b05e33c6',
+ 'lightbox-attachment-css' => 'ef078368',
'maniphest-task-summary-css' => '49898640',
- 'phabricator-action-list-view-css' => 'b05e33c6',
- 'phabricator-application-launch-view-css' => 'b05e33c6',
+ 'phabricator-action-list-view-css' => 'ef078368',
+ 'phabricator-application-launch-view-css' => 'ef078368',
'phabricator-busy' => '2c1dba03',
'phabricator-content-source-view-css' => '1084b12b',
- 'phabricator-core-css' => 'b05e33c6',
- 'phabricator-crumbs-view-css' => 'b05e33c6',
+ 'phabricator-core-css' => 'ef078368',
+ 'phabricator-crumbs-view-css' => 'ef078368',
'phabricator-drag-and-drop-file-upload' => '5e9e5c4e',
'phabricator-dropdown-menu' => '2c1dba03',
'phabricator-file-upload' => '2c1dba03',
- 'phabricator-filetree-view-css' => 'b05e33c6',
- 'phabricator-flag-css' => 'b05e33c6',
+ 'phabricator-filetree-view-css' => 'ef078368',
+ 'phabricator-flag-css' => 'ef078368',
'phabricator-hovercard' => '2c1dba03',
- 'phabricator-jump-nav' => 'b05e33c6',
+ 'phabricator-jump-nav' => 'ef078368',
'phabricator-keyboard-shortcut' => '2c1dba03',
'phabricator-keyboard-shortcut-manager' => '2c1dba03',
- 'phabricator-main-menu-view' => 'b05e33c6',
+ 'phabricator-main-menu-view' => 'ef078368',
'phabricator-menu-item' => '2c1dba03',
- 'phabricator-nav-view-css' => 'b05e33c6',
+ 'phabricator-nav-view-css' => 'ef078368',
'phabricator-notification' => '2c1dba03',
- 'phabricator-notification-css' => 'b05e33c6',
- 'phabricator-notification-menu-css' => 'b05e33c6',
+ 'phabricator-notification-css' => 'ef078368',
+ 'phabricator-notification-menu-css' => 'ef078368',
'phabricator-object-selector-css' => '1084b12b',
'phabricator-phtize' => '2c1dba03',
'phabricator-prefab' => '2c1dba03',
'phabricator-project-tag-css' => '49898640',
- 'phabricator-remarkup-css' => 'b05e33c6',
+ 'phabricator-remarkup-css' => 'ef078368',
'phabricator-shaped-request' => '5e9e5c4e',
- 'phabricator-side-menu-view-css' => 'b05e33c6',
- 'phabricator-standard-page-view' => 'b05e33c6',
- 'phabricator-tag-view-css' => 'b05e33c6',
+ 'phabricator-side-menu-view-css' => 'ef078368',
+ 'phabricator-standard-page-view' => 'ef078368',
+ 'phabricator-tag-view-css' => 'ef078368',
'phabricator-textareautils' => '2c1dba03',
'phabricator-tooltip' => '2c1dba03',
- 'phabricator-transaction-view-css' => 'b05e33c6',
- 'phabricator-zindex-css' => 'b05e33c6',
- 'phui-button-css' => 'b05e33c6',
- 'phui-form-css' => 'b05e33c6',
- 'phui-form-view-css' => 'b05e33c6',
- 'phui-header-view-css' => 'b05e33c6',
- 'phui-icon-view-css' => 'b05e33c6',
- 'phui-list-view-css' => 'b05e33c6',
- 'phui-object-item-list-view-css' => 'b05e33c6',
- 'phui-property-list-view-css' => 'b05e33c6',
- 'phui-spacing-css' => 'b05e33c6',
- 'sprite-apps-large-css' => 'b05e33c6',
- 'sprite-gradient-css' => 'b05e33c6',
- 'sprite-icons-css' => 'b05e33c6',
- 'sprite-menu-css' => 'b05e33c6',
- 'sprite-status-css' => 'b05e33c6',
- 'syntax-highlighting-css' => 'b05e33c6',
+ 'phabricator-transaction-view-css' => 'ef078368',
+ 'phabricator-zindex-css' => 'ef078368',
+ 'phui-button-css' => 'ef078368',
+ 'phui-form-css' => 'ef078368',
+ 'phui-form-view-css' => 'ef078368',
+ 'phui-header-view-css' => 'ef078368',
+ 'phui-icon-view-css' => 'ef078368',
+ 'phui-list-view-css' => 'ef078368',
+ 'phui-object-item-list-view-css' => 'ef078368',
+ 'phui-property-list-view-css' => 'ef078368',
+ 'phui-spacing-css' => 'ef078368',
+ 'sprite-apps-large-css' => 'ef078368',
+ 'sprite-gradient-css' => 'ef078368',
+ 'sprite-icons-css' => 'ef078368',
+ 'sprite-menu-css' => 'ef078368',
+ 'sprite-status-css' => 'ef078368',
+ 'syntax-highlighting-css' => 'ef078368',
),
));
Index: src/view/phui/PHUIObjectBoxView.php
===================================================================
--- src/view/phui/PHUIObjectBoxView.php
+++ src/view/phui/PHUIObjectBoxView.php
@@ -138,8 +138,13 @@
foreach ($this->propertyLists as $key => $list) {
$group = new PHUIPropertyGroupView();
+ $i = 0;
foreach ($list as $item) {
$group->addPropertyList($item);
+ if ($i > 0) {
+ $item->addClass('phui-property-list-section-noninitial');
+ }
+ $i++;
}
if ($this->tabs && $key != $default_key) {
Index: src/view/phui/PHUIPropertyListView.php
===================================================================
--- src/view/phui/PHUIPropertyListView.php
+++ src/view/phui/PHUIPropertyListView.php
@@ -7,6 +7,7 @@
private $object;
private $invokedWillRenderEvent;
private $actionList;
+ private $classes = array();
protected function canAppendChild() {
return false;
@@ -22,6 +23,11 @@
return $this;
}
+ public function addClass($class) {
+ $this->classes[] = $class;
+ return $this;
+ }
+
public function setHasKeyboardShortcuts($has_keyboard_shortcuts) {
$this->hasKeyboardShortcuts = $has_keyboard_shortcuts;
return $this;
@@ -110,11 +116,13 @@
throw new Exception(pht("Unknown part type '%s'!", $type));
}
}
+ $this->classes[] = 'phui-property-list-section';
+ $classes = implode(' ', $this->classes);
return phutil_tag(
'div',
array(
- 'class' => 'phui-property-list-section',
+ 'class' => $classes,
),
array(
$items,
Index: webroot/rsrc/css/phui/phui-property-list-view.css
===================================================================
--- webroot/rsrc/css/phui/phui-property-list-view.css
+++ webroot/rsrc/css/phui/phui-property-list-view.css
@@ -23,7 +23,8 @@
display: none;
}
-.phui-property-group-noninitial {
+.phui-property-group-noninitial,
+.phui-property-list-section-noninitial {
border-color: {$thinblueborder};
border-style: solid;
border-width: 1px 0 0;
@@ -85,6 +86,10 @@
border-width: 1px 0 0;
}
+.phui-property-list-section-noninitial .phui-property-list-section-header {
+ border-top: none;
+}
+
.device .phui-property-list-section-header {
padding-left: 8px;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Mar 6, 6:05 PM (9 h, 47 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7300343
Default Alt Text
D7492.diff (8 KB)
Attached To
Mode
D7492: Add a border to additional property lists in a group.
Attached
Detach File
Event Timeline
Log In to Comment