Page MenuHomePhabricator
Files F15294564

D15983.diff
No OneTemporary
Actions

D15983.diff
View Options

diff --git a/src/infrastructure/internationalization/management/PhabricatorInternationalizationManagementExtractWorkflow.php b/src/infrastructure/internationalization/management/PhabricatorInternationalizationManagementExtractWorkflow.php
--- a/src/infrastructure/internationalization/management/PhabricatorInternationalizationManagementExtractWorkflow.php
+++ b/src/infrastructure/internationalization/management/PhabricatorInternationalizationManagementExtractWorkflow.php
@@ -35,7 +35,7 @@
}
}
- $console->writeOut(
+ $console->writeErr(
"%s\n",
pht('Found %s file(s)...', phutil_count($futures)));
@@ -44,14 +44,24 @@
$bar = id(new PhutilConsoleProgressBar())
->setTotal(count($futures));
+ $messages = array();
+
$futures = id(new FutureIterator($futures))
->limit(8);
foreach ($futures as $full_path => $future) {
$bar->update(1);
- $tree = XHPASTTree::newFromDataAndResolvedExecFuture(
- Filesystem::readFile($full_path),
- $future->resolve());
+ try {
+ $tree = XHPASTTree::newFromDataAndResolvedExecFuture(
+ Filesystem::readFile($full_path),
+ $future->resolve());
+ } catch (Exception $ex) {
+ $messages[] = pht(
+ 'WARNING: Failed to extract strings from file "%s": %s',
+ $full_path,
+ $ex->getMessage());
+ continue;
+ }
$root = $tree->getRootNode();
$calls = $root->selectDescendantsOfType('n_FUNCTION_CALL');
@@ -69,7 +79,11 @@
'line' => $string_line,
);
} catch (Exception $ex) {
- // TODO: Deal with this junks.
+ $messages[] = pht(
+ 'WARNING: Failed to evaluate pht() call on line %d in "%s": %s',
+ $call->getLineNumber(),
+ $full_path,
+ $ex->getMessage());
}
}
}
@@ -78,6 +92,10 @@
}
$bar->done();
+ foreach ($messages as $message) {
+ $console->writeErr("%s\n", $message);
+ }
+
ksort($results);
$out = array();

File Metadata

Mime Type
text/plain
Expires
Mar 6 2025, 9:56 AM (6 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7233692
Default Alt Text
D15983.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility