Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15289535
D12198.id32755.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D12198.id32755.diff
View Options
diff --git a/src/lint/linter/ArcanistESLintLinter.php b/src/lint/linter/ArcanistESLintLinter.php
--- a/src/lint/linter/ArcanistESLintLinter.php
+++ b/src/lint/linter/ArcanistESLintLinter.php
@@ -14,8 +14,18 @@
return pht('ESLint is a linter for JavaScript source files.');
}
+ public function getVersion() {
+ $output = exec('eslint --version');
+
+ if (strpos($output, 'command not found') !== false) {
+ return false;
+ }
+
+ return $output;
+ }
+
public function getLinterName() {
- return 'ESLint';
+ return 'ESLINT';
}
public function getLinterConfigurationName() {
@@ -27,11 +37,7 @@
}
public function getInstallInstructions() {
- return pht('Install ESLint using `npm install -g eslint`.');
- }
-
- protected function canCustomizeLintSeverities() {
- return true;
+ return pht('Install ESLint using `%s`.', 'npm install -g eslint');
}
protected function parseLinterOutput($path, $err, $stdout, $stderr) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Mar 5, 10:00 PM (3 d, 6 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7227556
Default Alt Text
D12198.id32755.diff (1 KB)
Attached To
Mode
D12198: Added ESLint Support
Attached
Detach File
Event Timeline
Log In to Comment