Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15283974
D8697.id20629.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
854 B
Referenced Files
None
Subscribers
None
D8697.id20629.diff
View Options
diff --git a/src/applications/differential/storage/DifferentialTransactionComment.php b/src/applications/differential/storage/DifferentialTransactionComment.php
--- a/src/applications/differential/storage/DifferentialTransactionComment.php
+++ b/src/applications/differential/storage/DifferentialTransactionComment.php
@@ -44,12 +44,13 @@
$items = array();
foreach ($group as $inline) {
$comment = $inline->getComment();
- $num = (int)$comment->getLineNumber();
- $len = (int)$comment->getLineLength();
+ $num = $comment->getLineNumber();
+ $len = $comment->getLineLength();
+ $id = $comment->getID();
$items[] = array(
'inline' => $inline,
- 'sort' => ($num << 16) + $len,
+ 'sort' => sprintf('~%010d%010d%010d', $num, $len, $id),
);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Mar 5, 9:00 AM (10 h, 43 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7224399
Default Alt Text
D8697.id20629.diff (854 B)
Attached To
Mode
D8697: Sort inline comments by id in case of ties
Attached
Detach File
Event Timeline
Log In to Comment