D21760.diff
No OneTemporary
Actions

Size

899 B

Referenced Files

None

Subscribers

None

D21760.diff
View Options

	diff --git a/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php b/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php
	--- a/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php
	+++ b/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php
	@@ -141,9 +141,7 @@
	}
	}

	- // Find the smallest "new" changeset ID. We'll consider everything
	- // larger than this to be "newer", and everything smaller to be "older".
	- $first_new_id = min(mpull($new, 'getID'));
	+ $new_id_map = mpull($new, null, 'getID');

	$results = array();
	foreach ($inlines as $inline) {
	@@ -163,7 +161,7 @@

	$target_id = null;

	- if ($changeset_id >= $first_new_id) {
	+ if (isset($new_id_map[$changeset_id])) {
	$name_map = $name_map_new;
	$is_new = true;
	} else {