Page MenuHomePhabricator
Files F15199070

D16236.diff
No OneTemporary
Actions

D16236.diff
View Options

diff --git a/src/applications/phid/view/PHUIHandleView.php b/src/applications/phid/view/PHUIHandleView.php
--- a/src/applications/phid/view/PHUIHandleView.php
+++ b/src/applications/phid/view/PHUIHandleView.php
@@ -14,6 +14,7 @@
private $handleList;
private $handlePHID;
private $asTag;
+ private $asText;
private $useShortName;
private $showHovercard;
@@ -32,6 +33,11 @@
return $this;
}
+ public function setAsText($as_text) {
+ $this->asText = $as_text;
+ return $this;
+ }
+
public function setUseShortName($short) {
$this->useShortName = $short;
return $this;
@@ -55,6 +61,10 @@
return $tag;
}
+ if ($this->asText) {
+ return $handle->getLinkName();
+ }
+
if ($this->useShortName) {
$name = $handle->getName();
} else {
diff --git a/src/applications/transactions/storage/PhabricatorModularTransaction.php b/src/applications/transactions/storage/PhabricatorModularTransaction.php
--- a/src/applications/transactions/storage/PhabricatorModularTransaction.php
+++ b/src/applications/transactions/storage/PhabricatorModularTransaction.php
@@ -116,6 +116,11 @@
return parent::getColor();
}
+ public function attachViewer(PhabricatorUser $viewer) {
+ $this->getTransactionImplementation()->setViewer($viewer);
+ return parent::attachViewer($viewer);
+ }
+
final public function hasChangeDetails() {
if ($this->getTransactionImplementation()->hasChangeDetailView()) {
return true;
diff --git a/src/applications/transactions/storage/PhabricatorModularTransactionType.php b/src/applications/transactions/storage/PhabricatorModularTransactionType.php
--- a/src/applications/transactions/storage/PhabricatorModularTransactionType.php
+++ b/src/applications/transactions/storage/PhabricatorModularTransactionType.php
@@ -129,6 +129,18 @@
return $this->getStorage()->renderHandleLink($object_phid);
}
+ final protected function renderHandle($phid) {
+ $viewer = $this->getViewer();
+ $display = $viewer->renderHandle($phid);
+
+ $rendering_target = $this->getStorage()->getRenderingTarget();
+ if ($rendering_target == PhabricatorApplicationTransaction::TARGET_TEXT) {
+ $display->setAsText(true);
+ }
+
+ return $display;
+ }
+
final protected function newError($title, $message, $xaction = null) {
return new PhabricatorApplicationTransactionValidationError(
$this->getTransactionTypeConstant(),

File Metadata

Mime Type
text/plain
Expires
Mon, Feb 24, 6:29 AM (11 h, 26 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7185844
Default Alt Text
D16236.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility