Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15197364
D19587.id47105.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D19587.id47105.diff
View Options
diff --git a/src/applications/diffusion/controller/DiffusionBlameController.php b/src/applications/diffusion/controller/DiffusionBlameController.php
--- a/src/applications/diffusion/controller/DiffusionBlameController.php
+++ b/src/applications/diffusion/controller/DiffusionBlameController.php
@@ -118,10 +118,6 @@
$author_phid = $commit->getAuthorDisplayPHID();
}
- if (!$author_phid && $revision) {
- $author_phid = $revision->getAuthorPHID();
- }
-
if (!$author_phid) {
// This means we couldn't identify an author for the commit or the
// revision. We just render a blank for alignment.
@@ -137,6 +133,7 @@
$author_meta = array(
'tip' => $handles[$author_phid]->getName(),
'align' => 'E',
+ 'size' => 'auto',
);
}
diff --git a/src/applications/repository/phid/PhabricatorRepositoryIdentityPHIDType.php b/src/applications/repository/phid/PhabricatorRepositoryIdentityPHIDType.php
--- a/src/applications/repository/phid/PhabricatorRepositoryIdentityPHIDType.php
+++ b/src/applications/repository/phid/PhabricatorRepositoryIdentityPHIDType.php
@@ -30,6 +30,7 @@
array $handles,
array $objects) {
+ $avatar_uri = celerity_get_resource_uri('/rsrc/image/avatar.png');
foreach ($handles as $phid => $handle) {
$identity = $objects[$phid];
@@ -40,6 +41,7 @@
$handle->setName($name);
$handle->setURI($identity->getURI());
$handle->setIcon('fa-user');
+ $handle->setImageURI($avatar_uri);
}
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Feb 23, 10:59 PM (9 h, 42 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7187969
Default Alt Text
D19587.id47105.diff (1 KB)
Attached To
Mode
D19587: Migrate DiffusionBlameController to use repo identities
Attached
Detach File
Event Timeline
Log In to Comment