Page MenuHomePhabricator
Files F14873388

D13106.id31640.diff
No OneTemporary
Actions

D13106.id31640.diff
View Options

diff --git a/src/lint/linter/__tests__/ArcanistExternalLinterTestCase.php b/src/lint/linter/__tests__/ArcanistExternalLinterTestCase.php
--- a/src/lint/linter/__tests__/ArcanistExternalLinterTestCase.php
+++ b/src/lint/linter/__tests__/ArcanistExternalLinterTestCase.php
@@ -2,7 +2,7 @@
abstract class ArcanistExternalLinterTestCase extends ArcanistLinterTestCase {
- public final function testVersion() {
+ final public function testVersion() {
try {
$version = $this->getLinter()->getVersion();
$this->assertTrue(
diff --git a/src/lint/linter/__tests__/ArcanistLinterTestCase.php b/src/lint/linter/__tests__/ArcanistLinterTestCase.php
--- a/src/lint/linter/__tests__/ArcanistLinterTestCase.php
+++ b/src/lint/linter/__tests__/ArcanistLinterTestCase.php
@@ -10,7 +10,7 @@
*
* @return ArcanistLinter
*/
- protected final function getLinter() {
+ final protected function getLinter() {
$matches = null;
if (!preg_match('/^(\w+Linter)TestCase$/', get_class($this), $matches) ||
!is_subclass_of($matches[1], 'ArcanistLinter')) {
@@ -20,7 +20,7 @@
return newv($matches[1], array());
}
- public abstract function testLinter();
+ abstract public function testLinter();
/**
* Executes all tests from the specified subdirectory. If a linter is not
diff --git a/src/unit/engine/phutil/PhutilTestCase.php b/src/unit/engine/phutil/PhutilTestCase.php
--- a/src/unit/engine/phutil/PhutilTestCase.php
+++ b/src/unit/engine/phutil/PhutilTestCase.php
@@ -668,7 +668,7 @@
*
* @return map
*/
- private static final function getCallerInfo() {
+ final private static function getCallerInfo() {
$callee = array();
$caller = array();
$seen = false;
diff --git a/src/unit/parser/ArcanistPhpunitTestResultParser.php b/src/unit/parser/ArcanistPhpunitTestResultParser.php
--- a/src/unit/parser/ArcanistPhpunitTestResultParser.php
+++ b/src/unit/parser/ArcanistPhpunitTestResultParser.php
@@ -138,9 +138,9 @@
if ($line->getAttribute('type') != 'stmt') {
$coverage .= 'N';
} else {
- if ((int) $line->getAttribute('count') == 0) {
+ if ((int)$line->getAttribute('count') == 0) {
$coverage .= 'U';
- } else if ((int) $line->getAttribute('count') > 0) {
+ } else if ((int)$line->getAttribute('count') > 0) {
$coverage .= 'C';
}
}

File Metadata

Mime Type
text/plain
Expires
Sun, Feb 9, 5:20 AM (19 m, 41 s)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7106131
Default Alt Text
D13106.id31640.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility