Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14869473
D11987.id28868.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
901 B
Referenced Files
None
Subscribers
None
D11987.id28868.diff
View Options
diff --git a/src/applications/differential/render/DifferentialChangesetRenderer.php b/src/applications/differential/render/DifferentialChangesetRenderer.php
--- a/src/applications/differential/render/DifferentialChangesetRenderer.php
+++ b/src/applications/differential/render/DifferentialChangesetRenderer.php
@@ -518,7 +518,14 @@
$out[] = $old_buf;
$old_buf = array();
}
- $new_buf[] = $primitive;
+ if (!$primitive['htype']) {
+ // If this line is the same in both versions of the file, put it in
+ // the old line buffer. This makes sure inlines on old, unchanged
+ // lines end up in the right place.
+ $old_buf[] = $primitive;
+ } else {
+ $new_buf[] = $primitive;
+ }
} else if ($type == 'context' || $type == 'no-context') {
$out[] = $old_buf;
$out[] = $new_buf;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Feb 9, 2:53 AM (20 h, 52 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7104489
Default Alt Text
D11987.id28868.diff (901 B)
Attached To
Mode
D11987: Fix an issue where inlines appear in the wrong place in one-up views
Attached
Detach File
Event Timeline
Log In to Comment