Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14849663
D11442.id27703.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
11 KB
Referenced Files
None
Subscribers
None
D11442.id27703.diff
View Options
diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -8,10 +8,10 @@
return array(
'names' => array(
'core.pkg.css' => '30ec4610',
- 'core.pkg.js' => '55716d41',
+ 'core.pkg.js' => '026cd63d',
'darkconsole.pkg.js' => '8ab24e01',
'differential.pkg.css' => '8af45893',
- 'differential.pkg.js' => 'f437e70e',
+ 'differential.pkg.js' => '013bc653',
'diffusion.pkg.css' => '591664fa',
'diffusion.pkg.js' => 'bfc0737b',
'maniphest.pkg.css' => 'e34dfbec',
@@ -158,22 +158,22 @@
'rsrc/externals/font/fontawesome/fontawesome-webfont.woff' => '80526fc8',
'rsrc/externals/font/sourcesans/SourceSansPro.woff' => '3614608c',
'rsrc/externals/font/sourcesans/SourceSansProBold.woff' => 'cbf46566',
- 'rsrc/externals/javelin/core/Event.js' => '85ea0626',
- 'rsrc/externals/javelin/core/Stratcom.js' => '8b0ad945',
+ 'rsrc/externals/javelin/core/Event.js' => '2079dfb1',
+ 'rsrc/externals/javelin/core/Stratcom.js' => '6c53634d',
'rsrc/externals/javelin/core/__tests__/event-stop-and-kill.js' => '717554e4',
'rsrc/externals/javelin/core/__tests__/install.js' => 'c432ee85',
'rsrc/externals/javelin/core/__tests__/stratcom.js' => '88bf7313',
'rsrc/externals/javelin/core/__tests__/util.js' => 'e251703d',
- 'rsrc/externals/javelin/core/init.js' => '4df97779',
+ 'rsrc/externals/javelin/core/init.js' => 'd6327a9d',
'rsrc/externals/javelin/core/init_node.js' => 'c234aded',
- 'rsrc/externals/javelin/core/install.js' => '05270951',
+ 'rsrc/externals/javelin/core/install.js' => '0d31bd01',
'rsrc/externals/javelin/core/util.js' => '93cc50d6',
'rsrc/externals/javelin/docs/Base.js' => '74676256',
'rsrc/externals/javelin/docs/onload.js' => 'e819c479',
'rsrc/externals/javelin/ext/fx/Color.js' => '7e41274a',
'rsrc/externals/javelin/ext/fx/FX.js' => '54b612ba',
'rsrc/externals/javelin/ext/reactor/core/DynVal.js' => 'f6555212',
- 'rsrc/externals/javelin/ext/reactor/core/Reactor.js' => '2b8de964',
+ 'rsrc/externals/javelin/ext/reactor/core/Reactor.js' => '296c4426',
'rsrc/externals/javelin/ext/reactor/core/ReactorNode.js' => '1ad0a787',
'rsrc/externals/javelin/ext/reactor/core/ReactorNodeCalmer.js' => '76f4ebed',
'rsrc/externals/javelin/ext/reactor/dom/RDOM.js' => 'c90a04fc',
@@ -361,7 +361,7 @@
'rsrc/js/application/differential/behavior-keyboard-nav.js' => '2c426492',
'rsrc/js/application/differential/behavior-populate.js' => 'bdb3e4d0',
'rsrc/js/application/differential/behavior-show-field-details.js' => 'bba9eedf',
- 'rsrc/js/application/differential/behavior-show-more.js' => 'dd7e8ef5',
+ 'rsrc/js/application/differential/behavior-show-more.js' => '954d2de0',
'rsrc/js/application/differential/behavior-toggle-files.js' => 'ca3f91eb',
'rsrc/js/application/differential/behavior-user-select.js' => 'a8d8459d',
'rsrc/js/application/diffusion/DiffusionLocateFileSource.js' => 'b42eddc7',
@@ -565,7 +565,7 @@
'javelin-behavior-differential-keyboard-navigation' => '2c426492',
'javelin-behavior-differential-populate' => 'bdb3e4d0',
'javelin-behavior-differential-show-field-details' => 'bba9eedf',
- 'javelin-behavior-differential-show-more' => 'dd7e8ef5',
+ 'javelin-behavior-differential-show-more' => '954d2de0',
'javelin-behavior-differential-toggle-files' => 'ca3f91eb',
'javelin-behavior-differential-user-select' => 'a8d8459d',
'javelin-behavior-diffusion-commit-branches' => 'bdaf4d04',
@@ -650,15 +650,15 @@
'javelin-diffusion-locate-file-source' => 'b42eddc7',
'javelin-dom' => '2d66f6ec',
'javelin-dynval' => 'f6555212',
- 'javelin-event' => '85ea0626',
+ 'javelin-event' => '2079dfb1',
'javelin-fx' => '54b612ba',
'javelin-history' => 'c60f4327',
- 'javelin-install' => '05270951',
+ 'javelin-install' => '0d31bd01',
'javelin-json' => '69adf288',
'javelin-leader' => '331b1611',
- 'javelin-magical-init' => '4df97779',
+ 'javelin-magical-init' => 'd6327a9d',
'javelin-mask' => '8a41885b',
- 'javelin-reactor' => '2b8de964',
+ 'javelin-reactor' => '296c4426',
'javelin-reactor-dom' => 'c90a04fc',
'javelin-reactor-node-calmer' => '76f4ebed',
'javelin-reactornode' => '1ad0a787',
@@ -667,7 +667,7 @@
'javelin-routable' => 'b3e7d692',
'javelin-router' => '29274e2b',
'javelin-scrollbar' => '479fd9f1',
- 'javelin-stratcom' => '8b0ad945',
+ 'javelin-stratcom' => '6c53634d',
'javelin-tokenizer' => '7644823e',
'javelin-typeahead' => '70baed2f',
'javelin-typeahead-composite-source' => '503e17fd',
@@ -836,10 +836,6 @@
'javelin-vector',
'javelin-install',
),
- '05270951' => array(
- 'javelin-util',
- 'javelin-magical-init',
- ),
'065227cc' => array(
'javelin-behavior',
'javelin-dom',
@@ -875,6 +871,10 @@
'javelin-util',
'phabricator-notification-css',
),
+ '0d31bd01' => array(
+ 'javelin-util',
+ 'javelin-magical-init',
+ ),
'0ec56e1d' => array(
'javelin-behavior',
'javelin-dom',
@@ -938,6 +938,9 @@
'javelin-dom',
'javelin-reactor-dom',
),
+ '2079dfb1' => array(
+ 'javelin-install',
+ ),
'2290aeef' => array(
'javelin-install',
'javelin-dom',
@@ -970,6 +973,10 @@
'javelin-install',
'javelin-util',
),
+ '296c4426' => array(
+ 'javelin-install',
+ 'javelin-util',
+ ),
'2b228192' => array(
'javelin-behavior',
'javelin-dom',
@@ -977,10 +984,6 @@
'javelin-workflow',
'javelin-json',
),
- '2b8de964' => array(
- 'javelin-install',
- 'javelin-util',
- ),
'2be71d56' => array(
'javelin-install',
'javelin-util',
@@ -1273,6 +1276,12 @@
'javelin-install',
'javelin-util',
),
+ '6c53634d' => array(
+ 'javelin-install',
+ 'javelin-event',
+ 'javelin-util',
+ 'javelin-magical-init',
+ ),
'6d3e1947' => array(
'javelin-behavior',
'javelin-diffusion-locate-file-source',
@@ -1420,9 +1429,6 @@
'javelin-leader',
'phabricator-notification',
),
- '85ea0626' => array(
- 'javelin-install',
- ),
'87cb6b51' => array(
'javelin-behavior',
'javelin-dom',
@@ -1454,12 +1460,6 @@
'javelin-install',
'javelin-dom',
),
- '8b0ad945' => array(
- 'javelin-install',
- 'javelin-event',
- 'javelin-util',
- 'javelin-magical-init',
- ),
'8b3fd187' => array(
'javelin-install',
'javelin-util',
@@ -1518,6 +1518,13 @@
'javelin-resource',
'javelin-routable',
),
+ '954d2de0' => array(
+ 'javelin-behavior',
+ 'javelin-dom',
+ 'javelin-workflow',
+ 'javelin-util',
+ 'javelin-stratcom',
+ ),
'965cab65' => array(
'javelin-behavior',
'javelin-vector',
@@ -1753,13 +1760,6 @@
'javelin-util',
'phabricator-shaped-request',
),
- 'dd7e8ef5' => array(
- 'javelin-behavior',
- 'javelin-dom',
- 'javelin-workflow',
- 'javelin-util',
- 'javelin-stratcom',
- ),
'de2e896f' => array(
'javelin-behavior',
'javelin-dom',
diff --git a/support/lint/browser.jshintrc b/support/lint/browser.jshintrc
--- a/support/lint/browser.jshintrc
+++ b/support/lint/browser.jshintrc
@@ -13,7 +13,6 @@
"expr": true,
"loopfunc": true,
- "sub": true,
"globals": {
"JX": false,
diff --git a/webroot/rsrc/externals/javelin/core/Event.js b/webroot/rsrc/externals/javelin/core/Event.js
--- a/webroot/rsrc/externals/javelin/core/Event.js
+++ b/webroot/rsrc/externals/javelin/core/Event.js
@@ -224,7 +224,7 @@
*/
getNodeData : function(key) {
// Evade static analysis - JX.Stratcom
- return JX['Stratcom'].getData(this.getNode(key));
+ return JX.Stratcom.getData(this.getNode(key));
}
},
diff --git a/webroot/rsrc/externals/javelin/core/Stratcom.js b/webroot/rsrc/externals/javelin/core/Stratcom.js
--- a/webroot/rsrc/externals/javelin/core/Stratcom.js
+++ b/webroot/rsrc/externals/javelin/core/Stratcom.js
@@ -223,7 +223,7 @@
}
// Add a remove function to the listener
- listener['remove'] = function() {
+ listener.remove = function() {
if (listener._callback) {
delete listener._callback;
for (var ii = 0; ii < ids.length; ii++) {
diff --git a/webroot/rsrc/externals/javelin/core/init.js b/webroot/rsrc/externals/javelin/core/init.js
--- a/webroot/rsrc/externals/javelin/core/init.js
+++ b/webroot/rsrc/externals/javelin/core/init.js
@@ -46,7 +46,7 @@
makeHoldingQueue('behavior');
makeHoldingQueue('install-init');
- window['__DEV__'] = window['__DEV__'] || 0;
+ window.__DEV__ = window.__DEV__ || 0;
var loaded = false;
var onload = [];
@@ -58,7 +58,7 @@
master_event_queue.push(what);
// Evade static analysis - JX.Stratcom
- var Stratcom = JX['Stratcom'];
+ var Stratcom = JX.Stratcom;
if (Stratcom && Stratcom.ready) {
// Empty the queue now so that exceptions don't cause us to repeatedly
// try to handle events.
diff --git a/webroot/rsrc/externals/javelin/core/install.js b/webroot/rsrc/externals/javelin/core/install.js
--- a/webroot/rsrc/externals/javelin/core/install.js
+++ b/webroot/rsrc/externals/javelin/core/install.js
@@ -131,7 +131,7 @@
JX[name] = JX.createClass(junk);
if (initialize) {
- if (JX['Stratcom'] && JX['Stratcom'].ready) {
+ if (JX.Stratcom && JX.Stratcom.ready) {
initialize.apply(null);
} else {
// This is a holding queue, defined in init.js.
@@ -371,7 +371,7 @@
// Here and below, this nonstandard access notation is used to mask
// these callsites from the static analyzer. JX.Stratcom is always
// available by the time we hit these execution points.
- return JX['Stratcom'].invoke(
+ return JX.Stratcom.invoke(
'obj:' + type,
this.__class__.__path__.concat([this.__id__]),
{args : JX.$A(arguments).slice(1)});
@@ -386,7 +386,7 @@
JX.keys(this.__class__.__events__).join(', ') + '.');
}
}
- return JX['Stratcom'].listen(
+ return JX.Stratcom.listen(
'obj:' + type,
this.__id__,
JX.bind(this, function(e) {
@@ -403,7 +403,7 @@
JX.keys(this.__events__).join(', ') + '.');
}
}
- return JX['Stratcom'].listen(
+ return JX.Stratcom.listen(
'obj:' + type,
this.__name__,
JX.bind(this, function(e) {
diff --git a/webroot/rsrc/externals/javelin/ext/reactor/core/Reactor.js b/webroot/rsrc/externals/javelin/ext/reactor/core/Reactor.js
--- a/webroot/rsrc/externals/javelin/ext/reactor/core/Reactor.js
+++ b/webroot/rsrc/externals/javelin/ext/reactor/core/Reactor.js
@@ -82,8 +82,8 @@
streams.push(dynvals[ix].getChanges());
}
- var result = new JX['ReactorNode'](streams, valueNow);
- return new JX['DynVal'](result, valueNow());
+ var result = new JX.ReactorNode(streams, valueNow);
+ return new JX.DynVal(result, valueNow());
}
}
});
diff --git a/webroot/rsrc/js/application/differential/behavior-show-more.js b/webroot/rsrc/js/application/differential/behavior-show-more.js
--- a/webroot/rsrc/js/application/differential/behavior-show-more.js
+++ b/webroot/rsrc/js/application/differential/behavior-show-more.js
@@ -40,8 +40,8 @@
JX.DOM.setContent(container, 'Loading...');
JX.DOM.alterClass(context, 'differential-show-more-loading', true);
- if (!data['whitespace']) {
- data['whitespace'] = config.whitespace;
+ if (!data.whitespace) {
+ data.whitespace = config.whitespace;
}
new JX.Workflow(config.uri, data)
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Feb 5, 2:03 AM (3 h, 59 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7091215
Default Alt Text
D11442.id27703.diff (11 KB)
Attached To
Mode
D11442: Use dot notation in some places
Attached
Detach File
Event Timeline
Log In to Comment