Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14844658
D19406.id46428.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
824 B
Referenced Files
None
Subscribers
None
D19406.id46428.diff
View Options
diff --git a/src/applications/files/favicon/PhabricatorFaviconRef.php b/src/applications/files/favicon/PhabricatorFaviconRef.php
--- a/src/applications/files/favicon/PhabricatorFaviconRef.php
+++ b/src/applications/files/favicon/PhabricatorFaviconRef.php
@@ -247,7 +247,14 @@
$src_w = $template['width'];
$src_h = $template['height'];
- $template_data = $template['file']->loadFileData();
+ try {
+ $template_data = $template['file']->loadFileData();
+ } catch (Exception $ex) {
+ // In rare cases, we can end up with a corrupted or inaccessible file.
+ // If we do, just give up: otherwise, it's impossible to get pages to
+ // generate and not obvious how to fix it.
+ return null;
+ }
if (!function_exists('imagecreatefromstring')) {
return $template_data;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Feb 3, 5:33 PM (21 h, 27 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7087438
Default Alt Text
D19406.id46428.diff (824 B)
Attached To
Mode
D19406: Recover more gracefully when favicon configuration points at a corrupt/damaged file
Attached
Detach File
Event Timeline
Log In to Comment