Page MenuHomePhabricator

D20699.diff
No OneTemporary

D20699.diff

diff --git a/src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php b/src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php
--- a/src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php
+++ b/src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php
@@ -109,6 +109,15 @@
$dst_columns = $layout_engine->getColumns($dst_project->getPHID());
$dst_columns = mpull($dst_columns, null, 'getPHID');
+ // Prevent moves to milestones or subprojects by selecting their
+ // columns, since the implications aren't obvious and this doesn't
+ // work the same way as normal column moves.
+ foreach ($dst_columns as $key => $dst_column) {
+ if ($dst_column->getProxyPHID()) {
+ unset($dst_columns[$key]);
+ }
+ }
+
$has_column = false;
$dst_column = null;

File Metadata

Mime Type
text/plain
Expires
Mon, Feb 3, 1:38 PM (18 h, 36 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7087013
Default Alt Text
D20699.diff (932 B)

Event Timeline