Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14843549
D14680.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1014 B
Referenced Files
None
Subscribers
None
D14680.diff
View Options
diff --git a/src/applications/transactions/view/PhabricatorApplicationTransactionView.php b/src/applications/transactions/view/PhabricatorApplicationTransactionView.php
--- a/src/applications/transactions/view/PhabricatorApplicationTransactionView.php
+++ b/src/applications/transactions/view/PhabricatorApplicationTransactionView.php
@@ -383,9 +383,19 @@
}
foreach ($groups as $key => $group) {
- $group = msort($group, 'getActionStrength');
- $group = array_reverse($group);
- $groups[$key] = $group;
+ $results = array();
+
+ // Sort transactions within the group by action strength, then by
+ // within actions of similar strength.
+ $strength_groups = mgroup($group, 'getActionStrength');
+ krsort($strength_groups);
+ foreach ($strength_groups as $strength_group) {
+ foreach (msort($strength_group, 'getID') as $xaction) {
+ $results[] = $xaction;
+ }
+ }
+
+ $groups[$key] = $results;
}
return $groups;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Feb 3, 7:47 AM (11 h, 8 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7086516
Default Alt Text
D14680.diff (1014 B)
Attached To
Mode
D14680: Fix confusing ordering of similar actions in transaction groups
Attached
Detach File
Event Timeline
Log In to Comment