Page MenuHomePhabricator
Files F14787824

D16541.id39810.diff
No OneTemporary
Actions

D16541.id39810.diff
View Options

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -1652,6 +1652,8 @@
'PHUIInfoPanelExample' => 'applications/uiexample/examples/PHUIInfoPanelExample.php',
'PHUIInfoPanelView' => 'view/phui/PHUIInfoPanelView.php',
'PHUIInfoView' => 'view/form/PHUIInfoView.php',
+ 'PHUIInvisibleCharacterTestCase' => 'view/phui/__tests__/PHUIInvisibleCharacterTestCase.php',
+ 'PHUIInvisibleCharacterView' => 'view/phui/PHUIInvisibleCharacterView.php',
'PHUIListExample' => 'applications/uiexample/examples/PHUIListExample.php',
'PHUIListItemView' => 'view/phui/PHUIListItemView.php',
'PHUIListView' => 'view/phui/PHUIListView.php',
@@ -6319,6 +6321,8 @@
'PHUIInfoPanelExample' => 'PhabricatorUIExample',
'PHUIInfoPanelView' => 'AphrontView',
'PHUIInfoView' => 'AphrontView',
+ 'PHUIInvisibleCharacterTestCase' => 'PhabricatorTestCase',
+ 'PHUIInvisibleCharacterView' => 'AphrontView',
'PHUIListExample' => 'PhabricatorUIExample',
'PHUIListItemView' => 'AphrontTagView',
'PHUIListView' => 'AphrontTagView',
diff --git a/src/view/phui/PHUIInvisibleCharacterView.php b/src/view/phui/PHUIInvisibleCharacterView.php
new file mode 100644
--- /dev/null
+++ b/src/view/phui/PHUIInvisibleCharacterView.php
@@ -0,0 +1,93 @@
+<?php
+
+/**
+ * API for replacing whitespace characters and some control characters with
+ * their printable representations. This is useful for debugging and
+ * displaying more helpful error messages to users.
+ *
+ */
+final class PHUIInvisibleCharacterView extends AphrontView {
+
+ private $inputText;
+ private $plainText = false;
+
+ // This is a list of the common invisible characters that are
+ // actually typeable. Other invisible characters will simply
+ // be displayed as their hex representations.
+ private static $invisibleChars = array(
+ "\x00" => 'NULL',
+ "\t" => 'TAB',
+ "\n" => 'NEWLINE',
+ "\x20" => 'SPACE',
+ );
+
+ public function __construct($input_text) {
+ $this->inputText = $input_text;
+ }
+
+ public function setPlainText($plain_text) {
+ $this->plainText = $plain_text;
+ return $this;
+ }
+
+ public function getStringParts() {
+ $input_text = $this->inputText;
+ $text_array = phutil_utf8v($input_text);
+
+ for ($ii = 0; $ii < count($text_array); $ii++) {
+ $char = $text_array[$ii];
+ $char_hex = bin2hex($char);
+ if (array_key_exists($char, self::$invisibleChars)) {
+ $text_array[$ii] = array(
+ 'special' => true,
+ 'value' => '<'.self::$invisibleChars[$char].'>',
+ );
+ } else if (ord($char) < 32) {
+ $text_array[$ii] = array(
+ 'special' => true,
+ 'value' => '<0x'.$char_hex.'>',
+ );
+ } else {
+ $text_array[$ii] = array(
+ 'special' => false,
+ 'value' => $char,
+ );
+ }
+ }
+ return $text_array;
+ }
+
+ private function renderHtmlArray() {
+ $html_array = array();
+ $parts = $this->getStringParts();
+ foreach ($parts as $part) {
+ if ($part['special']) {
+ $html_array[] = phutil_tag(
+ 'span',
+ array('class' => 'invisible-special'),
+ $part['value']);
+ } else {
+ $html_array[] = $part['value'];
+ }
+ }
+ return $html_array;
+ }
+
+ private function renderPlainText() {
+ $parts = $this->getStringParts();
+ $res = '';
+ foreach ($parts as $part) {
+ $res .= $part['value'];
+ }
+ return $res;
+ }
+
+ public function render() {
+ if ($this->plainText) {
+ return $this->renderPlainText();
+ } else {
+ return $this->renderHtmlArray();
+ }
+ }
+
+}
diff --git a/src/view/phui/__tests__/PHUIInvisibleCharacterTestCase.php b/src/view/phui/__tests__/PHUIInvisibleCharacterTestCase.php
new file mode 100644
--- /dev/null
+++ b/src/view/phui/__tests__/PHUIInvisibleCharacterTestCase.php
@@ -0,0 +1,52 @@
+<?php
+
+final class PHUIInvisibleCharacterTestCase extends PhabricatorTestCase {
+
+ public function testEmptyString() {
+ $view = new PHUIInvisibleCharacterView('');
+ $res = $view->render();
+ $this->assertEqual($res, array());
+ }
+
+ public function testEmptyPlainText() {
+ $view = (new PHUIInvisibleCharacterView(''))
+ ->setPlainText(true);
+ $res = $view->render();
+ $this->assertEqual($res, '');
+ }
+
+ public function testWithNamedChars() {
+ $test_input = "\x00\n\t ";
+ $view = (new PHUIInvisibleCharacterView($test_input))
+ ->setPlainText(true);
+ $res = $view->render();
+ $this->assertEqual($res, '<NULL><NEWLINE><TAB><SPACE>');
+ }
+
+ public function testWithHexChars() {
+ $test_input = "abc\x01";
+ $view = (new PHUIInvisibleCharacterView($test_input))
+ ->setPlainText(true);
+ $res = $view->render();
+ $this->assertEqual($res, 'abc<0x01>');
+ }
+
+ public function testWithNamedAsHex() {
+ $test_input = "\x00\x0a\x09\x20";
+ $view = (new PHUIInvisibleCharacterView($test_input))
+ ->setPlainText(true);
+ $res = $view->render();
+ $this->assertEqual($res, '<NULL><NEWLINE><TAB><SPACE>');
+ }
+
+ public function testHtmlDecoration() {
+ $test_input = "a\x00\n\t ";
+ $view = new PHUIInvisibleCharacterView($test_input);
+ $res = $view->render();
+ $this->assertFalse($res[0] instanceof PhutilSafeHTML);
+ $this->assertTrue($res[1] instanceof PhutilSafeHTML);
+ $this->assertTrue($res[2] instanceof PhutilSafeHTML);
+ $this->assertTrue($res[3] instanceof PhutilSafeHTML);
+ $this->assertTrue($res[4] instanceof PhutilSafeHTML);
+ }
+}

File Metadata

Mime Type
text/plain
Expires
Sat, Jan 25, 4:15 PM (16 h, 14 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7049709
Default Alt Text
D16541.id39810.diff (5 KB)

Event Timeline

Phabricator · Built by Phacility